Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-10-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review103087
---


Vinod, can you please help review this again? Thanks.

- Guangya Liu


On 十月 13, 2015, 1:08 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated 十月 13, 2015, 1:08 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md c2e39b7ddb12a00cd7ce5ca78bb34af9ba67b3c0 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-10-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/
---

(Updated Oct. 13, 2015, 1:08 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Update upgrade.md for SUPPRESS related upgrade


Diffs (updated)
-

  docs/upgrades.md c2e39b7ddb12a00cd7ce5ca78bb34af9ba67b3c0 

Diff: https://reviews.apache.org/r/38578/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-10-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review102375
---


Patch looks great!

Reviews applied: [38578]

All tests passed.

- Mesos ReviewBot


On Oct. 13, 2015, 1:08 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated Oct. 13, 2015, 1:08 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md c2e39b7ddb12a00cd7ce5ca78bb34af9ba67b3c0 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review99864
---



docs/upgrades.md (line 30)


Use wording similar to what we used for 22.0

**NOTE** The C++/Java/Python scheduler bindings have been updated. In 
particular, the driver can make a suppressOffers() call to stop receiving 
offers (until reviveOffers() is called).



docs/upgrades.md (line 34)


what about slaves and executors?



docs/upgrades.md (line 36)


what does this have to do with explicit acks? did you forget to update the 
copy paste?


- Vinod Kone


On Sept. 21, 2015, 11:25 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated Sept. 21, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Vinod Kone 


> On Sept. 21, 2015, 11:32 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 34
> > 
> >
> > what about slaves and executors?
> 
> Guangya Liu wrote:
> Vinod, do we need to mention slaves and executors here as my change does 
> not impact both slave and executors but only scheduler. Comments? Thanks.

yea. we should because this is a generic upgrade order for the entire cluster.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review99864
---


On Sept. 21, 2015, 11:44 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated Sept. 21, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review99915
---


Patch looks great!

Reviews applied: [38578]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 11:44 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated Sept. 21, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu 


> On 九月 21, 2015, 11:32 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 34
> > 
> >
> > what about slaves and executors?
> 
> Guangya Liu wrote:
> Vinod, do we need to mention slaves and executors here as my change does 
> not impact both slave and executors but only scheduler. Comments? Thanks.
> 
> Vinod Kone wrote:
> yea. we should because this is a generic upgrade order for the entire 
> cluster.

Thanks Vinod, I have updated this in the latest RR.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review99864
---


On 九月 21, 2015, 11:44 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated 九月 21, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu 


> On 九月 21, 2015, 11:32 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 34
> > 
> >
> > what about slaves and executors?

Vinod, do we need to mention slaves and executors here as my change does not 
impact both slave and executors but only scheduler. Comments? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/#review99864
---


On 九月 21, 2015, 11:25 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38578/
> ---
> 
> (Updated 九月 21, 2015, 11:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update upgrade.md for SUPPRESS related upgrade
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 
> 
> Diff: https://reviews.apache.org/r/38578/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Update upgrade.md for SUPPRESS related upgrade


Diffs
-

  docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 

Diff: https://reviews.apache.org/r/38578/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38578/
---

(Updated 九月 21, 2015, 11:44 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Vinod's comments.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

Update upgrade.md for SUPPRESS related upgrade


Diffs (updated)
-

  docs/upgrades.md 8e33b9b90654a43a452f97fc66e969ecb0f3d6dd 

Diff: https://reviews.apache.org/r/38578/diff/


Testing
---


Thanks,

Guangya Liu