Re: Review Request 38816: add test case for docker remotePuller

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38816/
---

(Updated Oct. 2, 2015, 11:59 a.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Bugs: MESOS-3494
https://issues.apache.org/jira/browse/MESOS-3494


Repository: mesos


Description
---

add test case for docker remotePuller


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38816/diff/


Testing
---

make check (ubuntu 14.04) 

libevent and ssl enabled in configuration (e.g., '../configure --disable-java 
--disable-python --enable-libevent --enable-ssl --enable-debug')


Thanks,

Gilbert Song

Re: Review Request 38816: add test case for docker remotePuller

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38816/#review100928
---



src/tests/containerizer/provisioner_docker_tests.cpp (line 47)


Please add this along with others in the "../provisioner/docker/" block in 
alphabetical order.



src/tests/containerizer/provisioner_docker_tests.cpp (line 56)


We sort the block alphabetically.



src/tests/containerizer/provisioner_docker_tests.cpp (line 740)


You can re-use the RegistryClientTest fixture instead of creating a new one.



src/tests/containerizer/provisioner_docker_tests.cpp (line 771)


Wondering if you can refactor all of this so that SimpleGetBlob and this 
test can reuse the common code.



src/tests/containerizer/provisioner_docker_tests.cpp (line 961)


You will have to verify that the response blob saved in the file has the 
content you expected (clock::now)


- Jojy Varghese


On Sept. 28, 2015, 6:27 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38816/
> ---
> 
> (Updated Sept. 28, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-3494
> https://issues.apache.org/jira/browse/MESOS-3494
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> add test case for docker remotePuller
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38816/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04) 
> 
> libevent and ssl enabled in configuration (e.g., '../configure --disable-java 
> --disable-python --enable-libevent --enable-ssl --enable-debug')
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 38816: add test case for docker remotePuller

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38816/
---

(Updated Sept. 28, 2015, 6:27 p.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Summary (updated)
-

add test case for docker remotePuller


Bugs: MESOS-3494
https://issues.apache.org/jira/browse/MESOS-3494


Repository: mesos


Description
---

add test case for docker remotePuller


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38816/diff/


Testing
---

make check (ubuntu 14.04) 

libevent and ssl enabled in configuration (e.g., '../configure --disable-java 
--disable-python --enable-libevent --enable-ssl --enable-debug')


Thanks,

Gilbert Song