Re: Review Request 39002: Fixed sed command for Python protos generation.

2015-10-14 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review102614
---

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> ---
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
> Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current command didn't complete the protobuf generation and resulted in 
> an empty file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> ---
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Re: Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101501
---

Ship it!


Ship It!

- Anand Mazumdar


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> ---
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
> Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current command didn't complete the protobuf generation and resulted in 
> an empty file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> ---
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/
---

Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
Massenzio.


Repository: mesos


Description
---

The current command didn't complete the protobuf generation and resulted in an 
empty file.


Diffs
-

  src/Makefile.am e698927 

Diff: https://reviews.apache.org/r/39002/diff/


Testing
---

make check and verified that protobufs were properly generated


Thanks,

Isabel Jimenez



Re: Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101499
---

Ship it!


Ship It!

- Cong Wang


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> ---
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
> Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current command didn't complete the protobuf generation and resulted in 
> an empty file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> ---
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>