Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102609 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:26 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39097/ > --- > > (Updated Oct. 13, 2015, 6:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 > > Diff: https://reviews.apache.org/r/39097/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- (Updated Oct. 13, 2015, 6:26 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 Diff: https://reviews.apache.org/r/39097/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102549 --- LGTM. - Artem Harutyunyan On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39097/ > --- > > (Updated Oct. 13, 2015, 11:26 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 > > Diff: https://reviews.apache.org/r/39097/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102296 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 9:28 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39097/ > --- > > (Updated Oct. 9, 2015, 9:28 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 > > Diff: https://reviews.apache.org/r/39097/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- (Updated Oct. 10, 2015, 4:28 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 Diff: https://reviews.apache.org/r/39097/diff/ Testing --- Thanks, Alex Clemmer
Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config. Diffs - 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 Diff: https://reviews.apache.org/r/39097/diff/ Testing --- Thanks, Alex Clemmer