Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

2015-10-13 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102416
---

Ship it!


Ship It!

- Guangya Liu


On 十月 13, 2015, 8 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> ---
> 
> (Updated 十月 13, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change is introduced in dependant patch and we should update V1 proto as 
> well.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto eadbc9d 
> 
> Diff: https://reviews.apache.org/r/39099/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

2015-10-13 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102501
---

Ship it!


Ship It!

- Michael Park


On Oct. 13, 2015, 8 a.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> ---
> 
> (Updated Oct. 13, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change is introduced in dependant patch and we should update V1 proto as 
> well.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto eadbc9d 
> 
> Diff: https://reviews.apache.org/r/39099/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

2015-10-12 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102225
---


This one need a rebase

- Guangya Liu


On 十月 7, 2015, 7:10 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> ---
> 
> (Updated 十月 7, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change is introduced in dependant patch and we should update V1 proto as 
> well.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto eadbc9d 
> 
> Diff: https://reviews.apache.org/r/39099/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>