Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review103032 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:28 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39201/ > --- > > (Updated Oct. 13, 2015, 6:28 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > The Windows integration work will require us to support `stout/net.hpp`, > but this file includes `stout/os.hpp`, which would be onerous to port. > > To avoid having to port that entire file, we simply roped in what we > needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that > `process/future.hpp` now requires a direct inclusion of > `stout/check.hpp`. > > > Diffs > - > > 3rdparty/libprocess/include/process/future.hpp > 9006b8a83d03eab6e67de12a954110029b7d150e > > Diff: https://reviews.apache.org/r/39201/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/ --- (Updated Oct. 13, 2015, 6:28 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- The Windows integration work will require us to support `stout/net.hpp`, but this file includes `stout/os.hpp`, which would be onerous to port. To avoid having to port that entire file, we simply roped in what we needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that `process/future.hpp` now requires a direct inclusion of `stout/check.hpp`. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp 9006b8a83d03eab6e67de12a954110029b7d150e Diff: https://reviews.apache.org/r/39201/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review102297 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 9:31 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39201/ > --- > > (Updated Oct. 9, 2015, 9:31 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > The Windows integration work will require us to support `stout/net.hpp`, > but this file includes `stout/os.hpp`, which would be onerous to port. > > To avoid having to port that entire file, we simply roped in what we > needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that > `process/future.hpp` now requires a direct inclusion of > `stout/check.hpp`. > > > Diffs > - > > 3rdparty/libprocess/include/process/future.hpp > 9006b8a83d03eab6e67de12a954110029b7d150e > > Diff: https://reviews.apache.org/r/39201/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- The Windows integration work will require us to support `stout/net.hpp`, but this file includes `stout/os.hpp`, which would be onerous to port. To avoid having to port that entire file, we simply roped in what we needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that `process/future.hpp` now requires a direct inclusion of `stout/check.hpp`. Diffs - 3rdparty/libprocess/include/process/future.hpp 9006b8a83d03eab6e67de12a954110029b7d150e Diff: https://reviews.apache.org/r/39201/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review102154 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092, 39093, 39096, 39097, 39180, 39181, 39201] All tests passed. - Mesos ReviewBot On Oct. 10, 2015, 4:31 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39201/ > --- > > (Updated Oct. 10, 2015, 4:31 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > The Windows integration work will require us to support `stout/net.hpp`, > but this file includes `stout/os.hpp`, which would be onerous to port. > > To avoid having to port that entire file, we simply roped in what we > needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that > `process/future.hpp` now requires a direct inclusion of > `stout/check.hpp`. > > > Diffs > - > > 3rdparty/libprocess/include/process/future.hpp > 9006b8a83d03eab6e67de12a954110029b7d150e > > Diff: https://reviews.apache.org/r/39201/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
