Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-20 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/#review103279
---

Ship it!


- Joris Van Remoortere


On Oct. 19, 2015, 11:31 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39378/
> ---
> 
> (Updated Oct. 19, 2015, 11:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3649 and MESOS-3680
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3680
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `process/subprocess.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> d2341a53aac7c779668ee80983f73158fd44bff5 
> 
> Diff: https://reviews.apache.org/r/39378/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-19 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/
---

(Updated Oct. 19, 2015, 11:31 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3649 and MESOS-3680
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3680


Repository: mesos


Description
---

Windows: Added support for `process/subprocess.hpp`.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
d2341a53aac7c779668ee80983f73158fd44bff5 

Diff: https://reviews.apache.org/r/39378/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer



Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-16 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/#review102975
---

Ship it!


Ship It!

- Joseph Wu


On Oct. 16, 2015, 12:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39378/
> ---
> 
> (Updated Oct. 16, 2015, 12:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3649 and MESOS-3680
> https://issues.apache.org/jira/browse/MESOS-3649
> https://issues.apache.org/jira/browse/MESOS-3680
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `process/subprocess.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> d2341a53aac7c779668ee80983f73158fd44bff5 
> 
> Diff: https://reviews.apache.org/r/39378/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-16 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39378/
---

(Updated Oct. 16, 2015, 7:50 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3649 and MESOS-3680
https://issues.apache.org/jira/browse/MESOS-3649
https://issues.apache.org/jira/browse/MESOS-3680


Repository: mesos


Description
---

Windows: Added support for `process/subprocess.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
d2341a53aac7c779668ee80983f73158fd44bff5 

Diff: https://reviews.apache.org/r/39378/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer