Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-28 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review104367
---


Vinod, can you please help check if we can merge this? Thanks!

- Guangya Liu


On 十月 23, 2015, 12:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated 十月 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review103661
---

Ship it!



src/master/http.cpp (line 298)


if (slave.version.isSome()) {
  object.values["version" = slave.version.get();
}


- Vinod Kone


On Oct. 18, 2015, 1:29 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated Oct. 18, 2015, 1:29 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/
---

(Updated Oct. 23, 2015, 12:17 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Viond's comments


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add agent version to /master/slaves endpoint


Diffs (updated)
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 

Diff: https://reviews.apache.org/r/39421/diff/


Testing
---

root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
"http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
{
  "slaves": [
{
  "version": "0.26.0",  Here
  "used_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "unreserved_resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "reserved_resources": {},
  "active": true,
  "attributes": {},
  "hostname": "devstack007.cn.ibm.com",
  "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
  "offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "pid": "slave(1)@9.111.242.187:5051",
  "registered_time": 1445174743.70792,
  "reregistered_time": 1445174743.7085
}
  ]
}


Thanks,

Guangya Liu

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review103703
---


Patch looks great!

Reviews applied: [39421]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 12:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated Oct. 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add agent version to /master/slaves endpoint


Diffs
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 

Diff: https://reviews.apache.org/r/39421/diff/


Testing
---

root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
"http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
{
  "slaves": [
{
  "version": "0.26.0",  Here
  "used_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "unreserved_resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "reserved_resources": {},
  "active": true,
  "attributes": {},
  "hostname": "devstack007.cn.ibm.com",
  "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
  "offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "pid": "slave(1)@9.111.242.187:5051",
  "registered_time": 1445174743.70792,
  "reregistered_time": 1445174743.7085
}
  ]
}


Thanks,

Guangya Liu

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review103057
---


Patch looks great!

Reviews applied: [39421]

All tests passed.

- Mesos ReviewBot


On Oct. 18, 2015, 1:29 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated Oct. 18, 2015, 1:29 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>