Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-17 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/#review111059
---

Ship it!


Ship It!

- Jie Yu


On Dec. 17, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40168/
> ---
> 
> (Updated Dec. 17, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4178
> https://issues.apache.org/jira/browse/MESOS-4178
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
>   src/authorizer/local/authorizer.hpp 
> 965658b53d21734a2dbf3713d02d44d728fd6cca 
>   src/authorizer/local/authorizer.cpp 
> 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
>   src/tests/authorization_tests.cpp b5fb3c30e4c53bf3bf081c2a9a30a327f2c7c880 
>   src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/40168/diff/
> 
> 
> Testing
> ---
> 
> This is the third in a chain of 7 patches. New tests were added to 
> `authorization_tests.cpp` in order to test the authorizer's handling of both 
> successful and failed authorization attempts using `ACL::CreateVolume` and 
> `ACL::DestroyVolume`. `make check` was used to test after all patches were 
> applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-16 Thread Greg Mann 


> On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/authorizer/authorizer.hpp, lines 177-180
> > 
> >
> > We repeat this chunk again and again. I filed 
> > https://reviews.apache.org/r/41444/ to refactor it.

Thanks for that, I agree that these comments are too verbose.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/#review110644
---


On Dec. 17, 2015, 12:20 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40168/
> ---
> 
> (Updated Dec. 17, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4178
> https://issues.apache.org/jira/browse/MESOS-4178
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
>   src/authorizer/local/authorizer.hpp 
> 965658b53d21734a2dbf3713d02d44d728fd6cca 
>   src/authorizer/local/authorizer.cpp 
> 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
>   src/tests/authorization_tests.cpp b5fb3c30e4c53bf3bf081c2a9a30a327f2c7c880 
>   src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/40168/diff/
> 
> 
> Testing
> ---
> 
> This is the third in a chain of 7 patches. New tests were added to 
> `authorization_tests.cpp` in order to test the authorizer's handling of both 
> successful and failed authorization attempts using `ACL::CreateVolume` and 
> `ACL::DestroyVolume`. `make check` was used to test after all patches were 
> applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-16 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Dec. 17, 2015, 12:20 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-4178
https://issues.apache.org/jira/browse/MESOS-4178


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
  src/authorizer/local/authorizer.hpp 965658b53d21734a2dbf3713d02d44d728fd6cca 
  src/authorizer/local/authorizer.cpp 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
  src/tests/authorization_tests.cpp b5fb3c30e4c53bf3bf081c2a9a30a327f2c7c880 
  src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 
  src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 

Diff: https://reviews.apache.org/r/40168/diff/


Testing
---

This is the third in a chain of 7 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.


Thanks,

Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/#review110644
---



include/mesos/authorizer/authorizer.hpp (line 176)


Backtick `principal` and `volume_type` because they are parameter names? 
Same for destroy.



include/mesos/authorizer/authorizer.hpp (lines 177 - 180)


We repeat this chunk again and again. I filed 
https://reviews.apache.org/r/41444/ to refactor it.



include/mesos/authorizer/authorizer.hpp (line 182)


Backtick `ACL::CreateVolume`?



include/mesos/authorizer/authorizer.hpp (line 201)


Backtick `ACL::DestroyVolume`?


- Alexander Rukletsov


On Dec. 15, 2015, 9:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40168/
> ---
> 
> (Updated Dec. 15, 2015, 9:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4178
> https://issues.apache.org/jira/browse/MESOS-4178
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
>   src/authorizer/local/authorizer.hpp 
> 965658b53d21734a2dbf3713d02d44d728fd6cca 
>   src/authorizer/local/authorizer.cpp 
> 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
>   src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
>   src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/40168/diff/
> 
> 
> Testing
> ---
> 
> This is the third in a chain of 7 patches. New tests were added to 
> `authorization_tests.cpp` in order to test the authorizer's handling of both 
> successful and failed authorization attempts using `ACL::CreateVolume` and 
> `ACL::DestroyVolume`. `make check` was used to test after all patches were 
> applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Dec. 15, 2015, 9:18 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-4178
https://issues.apache.org/jira/browse/MESOS-4178


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
  src/authorizer/local/authorizer.hpp 965658b53d21734a2dbf3713d02d44d728fd6cca 
  src/authorizer/local/authorizer.cpp 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
  src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
  src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
  src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 

Diff: https://reviews.apache.org/r/40168/diff/


Testing
---

This is the third in a chain of 7 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.


Thanks,

Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-08 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Dec. 8, 2015, 6:07 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Rebase, updated comment.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b 
  src/authorizer/local/authorizer.hpp 965658b53d21734a2dbf3713d02d44d728fd6cca 
  src/authorizer/local/authorizer.cpp 1ac6a41d20454515a3ef2b84e296494a4592b3ea 
  src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
  src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
  src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 

Diff: https://reviews.apache.org/r/40168/diff/


Testing (updated)
---

This is the third in a chain of 7 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.


Thanks,

Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Nov. 14, 2015, 12:23 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40168/diff/


Testing
---

This is the third in a chain of 7 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.


Thanks,

Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Nov. 13, 2015, 1:20 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Summary (updated)
-

[3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40168/diff/


Testing
---

This is the third in a chain of 6 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.


Thanks,

Greg Mann

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
---

(Updated Nov. 13, 2015, 1:22 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40168/diff/


Testing (updated)
---

This is the third in a chain of 7 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.


Thanks,

Greg Mann