Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-24 Thread Guangya Liu 


> On 十一月 24, 2015, 9:38 p.m., Michael Park wrote:
> > Ship It!

@mcypark and @Neil, shall we clarify that the dynamic reservation works for 
both enabling and not enabling authorization in the document?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107853
---


On 十一月 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-24 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107853
---

Ship it!


Ship It!

- Michael Park


On Nov. 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

(Updated Nov. 23, 2015, 11:44 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs (updated)
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-21 Thread Guangya Liu 


> On 十一月 19, 2015, 2:44 a.m., Guangya Liu wrote:
> > docs/reservation.md, line 242
> > 
> >
> > This will not work if end user did not enable autheration, a JIRA 
> > ticket is tracing this MESOS-3940, shall we highlight the issue here before 
> > get resolved?
> 
> Neil Conway wrote:
> I think this is okay -- the issue should be fixed shortly.

I think that we should at least clarify that the dynamic reservation works for 
both enabling and not enabling authorization in the document, it is not a MUST 
we always put : in the CURL request, thoughts?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107117
---


On 十一月 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

(Updated Nov. 20, 2015, 10:32 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs (updated)
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-19 Thread Neil Conway 


> On Nov. 19, 2015, 2:44 a.m., Guangya Liu wrote:
> > docs/reservation.md, line 242
> > 
> >
> > This will not work if end user did not enable autheration, a JIRA 
> > ticket is tracing this MESOS-3940, shall we highlight the issue here before 
> > get resolved?

I think this is okay -- the issue should be fixed shortly.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107117
---


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-18 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs (updated)
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-18 Thread Neil Conway 


> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/home.md, line 40
> > 
> >
> > `s/for use by a role/for a role/`? `to be used by a role`?

Personally, I think "for use by a role" is the clearest way to phrase this.


> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/reservation.md, lines 244-262
> > 
> >
> > Do these backslashes need to be removed in order for copy/paste to work?

Yes.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106960
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107092
---



docs/persistent-volume.md (line 235)


Should we update this line to specify the latest version, since this 
feature hasn't come yet?


- Greg Mann


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107117
---



docs/reservation.md (line 242)


This will not work if end user did not enable autheration, a JIRA ticket is 
tracing this MESOS-3940, shall we highlight the issue here before get resolved?


- Guangya Liu


On 十一月 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106960
---



docs/home.md (line 40)


`s/for use by a role/for a role/`? `to be used by a role`?



docs/persistent-volume.md (lines 70 - 71)


`s/with//`?



docs/persistent-volume.md (line 177)


`... which can be used to specify ...` to stay consistent with above?



docs/reservation.md (line 60)


Given that we're introducing the
```
### Operator HTTP Endpoints
```
section below, I think we should also introduce

```
### Framework Scheduler API
```

and push the others to

```
 `Offer::Operation::Reserve`
 `Offer::Operation::Unreserve`
```

What do you think?



docs/reservation.md (lines 244 - 262)


Do these backslashes need to be removed in order for copy/paste to work?


- Michael Park


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-17 Thread Guangya Liu 


> On 十一月 13, 2015, 2:45 a.m., Guangya Liu wrote:
> > docs/reservation.md, line 242
> > 
> >
> > Not yours, but I have a question: currently, the HTTP endpoint for 
> > dynamic reservation request :, otherwise the 
> > request will be failed. In my understanding, we should enable the HTTP 
> > endpoint in the case the end user is not using anthentication? Comments?
> 
> Michael Park wrote:
> Guangya, I just looked into this a little bit. It looks to me that it's 
> my bug. When authentication is disabled, everything should be considered 
> authorized. This is currently not the case... I've filed 
> [MESOS-3940](https://issues.apache.org/jira/browse/MESOS-3940) to capture the 
> issue.

Thanks Michael for filing the JIRA to trace this ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106357
---


On 十一月 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-17 Thread Michael Park 


> On Nov. 13, 2015, 2:45 a.m., Guangya Liu wrote:
> > docs/reservation.md, line 242
> > 
> >
> > Not yours, but I have a question: currently, the HTTP endpoint for 
> > dynamic reservation request :, otherwise the 
> > request will be failed. In my understanding, we should enable the HTTP 
> > endpoint in the case the end user is not using anthentication? Comments?

Guangya, I just looked into this a little bit. It looks to me that it's my bug. 
When authentication is disabled, everything should be considered authorized. 
This is currently not the case... I've filed 
[MESOS-3940](https://issues.apache.org/jira/browse/MESOS-3940) to capture the 
issue.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106357
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-13 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

(Updated Nov. 13, 2015, 12:45 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs (updated)
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway

Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-12 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

Review request for mesos, Greg Mann and Michael Park.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway