Re: Review Request 40305: Added URI fetcher interface.

2015-11-20 Thread Jie Yu 


> On Nov. 18, 2015, 7:39 p.m., Vinod Kone wrote:
> > include/mesos/uri/fetcher.hpp, line 49
> > 
> >
> > Plugin might be confusing with Module.
> > 
> > Not sure what's a better alternative name is, Downloader? Schema?

Schema is not good because one Plugin can handle more than one schemes. I 
couldn't find a better name. Since Plugin is within Fetcher namespace, and will 
always be used like Fetcher::Plugin. So I think it shouldn't cause confusion to 
Module.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/#review107073
---


On Nov. 19, 2015, 6:30 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40305/
> ---
> 
> (Updated Nov. 19, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-3922
> https://issues.apache.org/jira/browse/MESOS-3922
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/uri/fetcher.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40305/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40305: Added URI fetcher interface.

2015-11-18 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/#review107073
---

Ship it!



include/mesos/uri/fetcher.hpp (line 49)


Plugin might be confusing with Module.

Not sure what's a better alternative name is, Downloader? Schema?


- Vinod Kone


On Nov. 16, 2015, 7:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40305/
> ---
> 
> (Updated Nov. 16, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/uri/fetcher.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40305/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40305: Added URI fetcher interface.

2015-11-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/
---

(Updated Nov. 18, 2015, 11:25 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-3922
https://issues.apache.org/jira/browse/MESOS-3922


Repository: mesos


Description
---

Added URI fetcher interface.


Diffs
-

  include/mesos/uri/fetcher.hpp PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/uri/fetcher.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40305/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40305: Added URI fetcher interface.

2015-11-16 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/
---

(Updated Nov. 16, 2015, 7:06 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
---

Moved to public headers.


Repository: mesos


Description
---

Added URI fetcher interface.


Diffs (updated)
-

  include/mesos/uri/fetcher.hpp PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/uri/fetcher.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40305/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40305: Added URI fetcher interface.

2015-11-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/#review106728
---


Patch looks great!

Reviews applied: [40250, 40251, 40252, 40274, 40253, 40305]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 7:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40305/
> ---
> 
> (Updated Nov. 16, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/uri/fetcher.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40305/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 40305: Added URI fetcher interface.

2015-11-13 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/
---

Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Repository: mesos


Description
---

Added URI fetcher interface.


Diffs
-

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
  src/uri/fetcher/fetcher.hpp PRE-CREATION 
  src/uri/fetcher/fetcher.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40305/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40305: Added URI fetcher interface.

2015-11-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/#review106500
---


Patch looks great!

Reviews applied: [40250, 40251, 40252, 40274, 40253, 40305]

All tests passed.

- Mesos ReviewBot


On Nov. 13, 2015, 6:47 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40305/
> ---
> 
> (Updated Nov. 13, 2015, 6:47 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/uri/fetcher/fetcher.hpp PRE-CREATION 
>   src/uri/fetcher/fetcher.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40305/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>