Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 1:06 a.m.) Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4107 https://issues.apache.org/jira/browse/MESOS-4107 Repository: mesos Description --- Windows: Added threadsafe `strerror_r` implementaiton. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/40382/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review109652 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015, 1:06 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40382/ > --- > > (Updated Dec. 10, 2015, 1:06 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-4107 > https://issues.apache.org/jira/browse/MESOS-4107 > > > Repository: mesos > > > Description > --- > > Windows: Added threadsafe `strerror_r` implementaiton. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > 71689089a7818e3465e7e51becc43c7836b67240 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/40382/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 12:08 a.m.) Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Windows: Added threadsafe `strerror_r` implementaiton. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/40382/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
> On Nov. 17, 2015, 9:11 p.m., Joseph Wu wrote: > > Since the Windows build was broken by this > > (https://reviews.apache.org/r/39005/), you may want to separate this commit > > from the chain. The reason I put it at the end is because I briefly thought that it would be unwise to get caught up in the refactoring of `Windows.hpp`, but now that I think about it, I think those commits have all been committed. Conclusion: 25 reviews is too many to keep track of. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106937 --- On Nov. 17, 2015, 10:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40382/ > --- > > (Updated Nov. 17, 2015, 10:59 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added threadsafe `strerror_r` implementaiton. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > 71689089a7818e3465e7e51becc43c7836b67240 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/40382/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106937 --- Ship it! Since the Windows build was broken by this (https://reviews.apache.org/r/39005/), you may want to separate this commit from the chain. - Joseph Wu On Nov. 17, 2015, 2:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40382/ > --- > > (Updated Nov. 17, 2015, 2:59 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added threadsafe `strerror_r` implementaiton. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > 71689089a7818e3465e7e51becc43c7836b67240 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/40382/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106851 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019, 39802, 39803, 39804, 39805, 39834, 39850, 39851, 39852, 39888, 39889, 40102, 40382] All tests passed. - Mesos ReviewBot On Nov. 17, 2015, 10:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40382/ > --- > > (Updated Nov. 17, 2015, 10:59 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added threadsafe `strerror_r` implementaiton. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp > 71689089a7818e3465e7e51becc43c7836b67240 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/40382/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Nov. 17, 2015, 10:59 a.m.) Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu. Summary (updated) - Windows: Added threadsafe `strerror_r` implementation. Repository: mesos Description --- Windows: Added threadsafe `strerror_r` implementaiton. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 Diff: https://reviews.apache.org/r/40382/diff/ Testing --- Thanks, Alex Clemmer