Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-12-03 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40557/#review108828
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 20, 2015, 11:52 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40557/
> ---
> 
> (Updated Nov. 20, 2015, 11:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on a discussion here: https://reviews.apache.org/r/40501/#review107290
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5 
> 
> Diff: https://reviews.apache.org/r/40557/diff/
> 
> 
> Testing
> ---
> 
> Checked README.md rendering on GitHub.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-11-20 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40557/
---

Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Neil Conway.


Repository: mesos


Description
---

Based on a discussion here: https://reviews.apache.org/r/40501/#review107290


Diffs
-

  3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5 

Diff: https://reviews.apache.org/r/40557/diff/


Testing
---

Checked README.md rendering on GitHub.


Thanks,

Joseph Wu

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-11-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40557/#review107395
---

Ship it!



3rdparty/libprocess/README.md (line 139)


Why is this taking about `Process*`? i.e., same issues would exist with a 
stack-allocated `Process`, for which (user code) never gets a `Process*`.


- Neil Conway


On Nov. 20, 2015, 7:04 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40557/
> ---
> 
> (Updated Nov. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on a discussion here: https://reviews.apache.org/r/40501/#review107290
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5 
> 
> Diff: https://reviews.apache.org/r/40557/diff/
> 
> 
> Testing
> ---
> 
> Checked README.md rendering on GitHub.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>