Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-19 Thread Gilbert Song 


> On Dec. 18, 2015, 5:18 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 407
> > 
> >
> > Do we have a test for this?

Yes, we do. I wrote a test case for it, but did not post that test. Becuase I 
am not sure whether we should have that test in docker_tests (which looks a 
little strange. 

Here is the test I just posted:
https://reviews.apache.org/r/41589/


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/#review111332
---


On Dec. 19, 2015, 5:35 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40838/
> ---
> 
> (Updated Dec. 19, 2015, 5:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Timothy Chen.
> 
> 
> Bugs: MESOS-4046
> https://issues.apache.org/jira/browse/MESOS-4046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Environment variable: Implemented `Env` specified in docker image returned 
> from docker pull.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
> 
> Diff: https://reviews.apache.org/r/40838/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/
---

(Updated Dec. 19, 2015, 5:35 p.m.)


Review request for mesos, Artem Harutyunyan and Timothy Chen.


Bugs: MESOS-4046
https://issues.apache.org/jira/browse/MESOS-4046


Repository: mesos


Description
---

Environment variable: Implemented `Env` specified in docker image returned from 
docker pull.


Diffs (updated)
-

  src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
  src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 

Diff: https://reviews.apache.org/r/40838/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-18 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/#review111332
---



src/docker/docker.cpp (line 363)


Remove extra line.



src/docker/docker.cpp (line 403)


Do we have a test for this?


- Timothy Chen


On Dec. 9, 2015, 6:41 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40838/
> ---
> 
> (Updated Dec. 9, 2015, 6:41 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Timothy Chen.
> 
> 
> Bugs: MESOS-4046
> https://issues.apache.org/jira/browse/MESOS-4046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Environment variable: Implemented `Env` specified in docker image returned 
> from docker pull.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
> 
> Diff: https://reviews.apache.org/r/40838/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-09 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/
---

(Updated Dec. 9, 2015, 10:41 a.m.)


Review request for mesos, Artem Harutyunyan and Timothy Chen.


Bugs: MESOS-4046
https://issues.apache.org/jira/browse/MESOS-4046


Repository: mesos


Description
---

Environment variable: Implemented `Env` specified in docker image returned from 
docker pull.


Diffs (updated)
-

  src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
  src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 

Diff: https://reviews.apache.org/r/40838/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-02 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/
---

(Updated Dec. 2, 2015, 2:09 p.m.)


Review request for mesos, Artem Harutyunyan and Timothy Chen.


Summary (updated)
-

Environment variable: Implemented `Env` specified in docker image returned from 
docker pull.


Bugs: MESOS-4046
https://issues.apache.org/jira/browse/MESOS-4046


Repository: mesos


Description (updated)
---

Environment variable: Implemented `Env` specified in docker image returned from 
docker pull.


Diffs (updated)
-

  src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
  src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 

Diff: https://reviews.apache.org/r/40838/diff/


Testing (updated)
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song