Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

2016-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/#review121518
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 118)


style.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp (line 19)


new line.


- Joris Van Remoortere


On March 1, 2016, 10:07 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40938/
> ---
> 
> (Updated March 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Mark `os::chroot` as deleted on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
> 
> Diff: https://reviews.apache.org/r/40938/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: make.bat
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

2016-03-01 Thread Daniel Pravat 


> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, 
> > line 30
> > 
> >
> > remove newline

I don't see it. Maybe in the old version of os.hpp


> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, 
> > line 23
> > 
> >
> > remove new line

I don't see it. Maybe in the old version of os.hpp


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/#review121509
---


On March 1, 2016, 10:07 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40938/
> ---
> 
> (Updated March 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Mark `os::chroot` as deleted on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
> 
> Diff: https://reviews.apache.org/r/40938/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: make.bat
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

2016-03-01 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/
---

(Updated March 1, 2016, 10:07 p.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.


Summary (updated)
-

Stout: Mark `os::chroot` as deleted on Windows.


Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780


Repository: mesos


Description (updated)
---

Stout: Mark `os::chroot` as deleted on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
f1d38029eef7e89dfdb8915158fba17865e6855b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
d917a99a46841156dc1e359c44010938cc45e943 

Diff: https://reviews.apache.org/r/40938/diff/


Testing
---

OSX: make check
Windows: make.bat


Thanks,

Daniel Pravat