Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-15 Thread Jie Yu 


> On Dec. 15, 2015, 8:25 a.m., Timothy Chen wrote:
> > src/slave/containerizer/fetcher.cpp, line 287
> > 
> >
> > Shouldn't we need to check for isDiscard as well?

Good catch! I'll change all of them.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40946/#review110451
---


On Dec. 15, 2015, 1:27 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40946/
> ---
> 
> (Updated Dec. 15, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
> https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made HDFS::du asynchrounous.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
>   src/slave/containerizer/fetcher.cpp 
> e479bd377d73254d4ad256ea931596fd6cb26035 
> 
> Diff: https://reviews.apache.org/r/40946/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-15 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40946/#review110451
---



src/slave/containerizer/fetcher.cpp (line 287)


Shouldn't we need to check for isDiscard as well?


- Timothy Chen


On Dec. 15, 2015, 1:27 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40946/
> ---
> 
> (Updated Dec. 15, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
> https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made HDFS::du asynchrounous.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
>   src/slave/containerizer/fetcher.cpp 
> e479bd377d73254d4ad256ea931596fd6cb26035 
> 
> Diff: https://reviews.apache.org/r/40946/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-04 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40946/#review109060
---

Ship it!


Ship It!

- Vinod Kone


On Dec. 4, 2015, 1:34 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40946/
> ---
> 
> (Updated Dec. 4, 2015, 1:34 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
> https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made HDFS::du asynchrounous.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
>   src/slave/containerizer/fetcher.cpp 
> 26df3d5c55dde9f11b497b4808316e33a3fe395c 
> 
> Diff: https://reviews.apache.org/r/40946/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40946/#review108930
---


Patch looks great!

Reviews applied: [40941, 40806, 40942, 40943, 40945, 40946]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 4, 2015, 1:34 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40946/
> ---
> 
> (Updated Dec. 4, 2015, 1:34 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
> https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made HDFS::du asynchrounous.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
>   src/slave/containerizer/fetcher.cpp 
> 26df3d5c55dde9f11b497b4808316e33a3fe395c 
> 
> Diff: https://reviews.apache.org/r/40946/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>