Re: Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41237/#review109933
---


Patch looks great!

Reviews applied: [41235, 41236, 41237]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 11, 2015, 2:01 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41237/
> ---
> 
> (Updated Dec. 11, 2015, 2:01 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed a function parameter in Docker puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 31bcc86e0e63e6535dcb62d61201c2ef310bf90d 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
> 
> Diff: https://reviews.apache.org/r/41237/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-11 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41237/#review109976
---

Ship it!


Ship It!

- Gilbert Song


On Dec. 10, 2015, 6:01 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41237/
> ---
> 
> (Updated Dec. 10, 2015, 6:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed a function parameter in Docker puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 31bcc86e0e63e6535dcb62d61201c2ef310bf90d 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
> 
> Diff: https://reviews.apache.org/r/41237/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-10 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41237/
---

Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Repository: mesos


Description
---

Renamed a function parameter in Docker puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
31bcc86e0e63e6535dcb62d61201c2ef310bf90d 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
4aa4a9c4074d96c30c3bceea59d071feeecae2ea 

Diff: https://reviews.apache.org/r/41237/diff/


Testing
---

make check


Thanks,

Jie Yu