Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

> On 十二月 17, 2015, 10:43 a.m., Klaus Ma wrote:
> > src/slave/slave.cpp, line 5194
> > 
> >
> > So we are going to only cover `SCALAR` resources? Is that necessary?

metrics/snapshot should expose metrics on allocation slack resources (allocated 
and available), the limitation is that only SCALAR resources will be covered 
for now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/#review110934
---


On 一月 3, 2016, 1:31 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41250/
> ---
> 
> (Updated 一月 3, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4124
> https://issues.apache.org/jira/browse/MESOS-4124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled slave get ALLOCATION_SLACK metrics.
> 
> 
> Diffs
> -
> 
>   src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
>   src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
>   src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
> 
> Diff: https://reviews.apache.org/r/41250/diff/
> 
> 
> Testing
> ---
> 
> $ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
> allocation_slack
>   "slave/cpus_allocation_slack_percent": 0,
>   "slave/cpus_allocation_slack_total": 3,
>   "slave/cpus_allocation_slack_used": 0,
>   "slave/disk_allocation_slack_percent": 0,
>   "slave/disk_allocation_slack_total": 0,
>   "slave/disk_allocation_slack_used": 0,
>   "slave/mem_allocation_slack_percent": 0,
>   "slave/mem_allocation_slack_total": 1000,
>   "slave/mem_allocation_slack_used": 0,
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/#review110934
---



src/slave/slave.cpp (line 5194)


So we are going to only cover `SCALAR` resources? Is that necessary?


- Klaus Ma


On Dec. 14, 2015, 3:13 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41250/
> ---
> 
> (Updated Dec. 14, 2015, 3:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Bugs: MESOS-4124
> https://issues.apache.org/jira/browse/MESOS-4124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled slave get ALLOCATION_SLACK metrics.
> 
> 
> Diffs
> -
> 
>   src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
>   src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 
> 
> Diff: https://reviews.apache.org/r/41250/diff/
> 
> 
> Testing
> ---
> 
> $ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
> alloc_slack
>   "slave/cpus_alloc_slack_revocable_percent": 0,
>   "slave/cpus_alloc_slack_revocable_total": 3,
>   "slave/cpus_alloc_slack_revocable_used": 0,
>   "slave/disk_alloc_slack_revocable_percent": 0,
>   "slave/disk_alloc_slack_revocable_total": 0,
>   "slave/disk_alloc_slack_revocable_used": 0,
>   "slave/mem_alloc_slack_revocable_percent": 0,
>   "slave/mem_alloc_slack_revocable_total": 1000,
>   "slave/mem_alloc_slack_revocable_used": 0,
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/
---

(Updated Dec. 13, 2015, 3:08 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
---

Enabled slave get ALLOCATION_SLACK metrics.


Diffs (updated)
-

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41250/diff/


Testing
---

$ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
alloc_slack
  "slave/cpus_alloc_slack_revocable_percent": 0,
  "slave/cpus_alloc_slack_revocable_total": 3,
  "slave/cpus_alloc_slack_revocable_used": 0,
  "slave/disk_alloc_slack_revocable_percent": 0,
  "slave/disk_alloc_slack_revocable_total": 0,
  "slave/disk_alloc_slack_revocable_used": 0,
  "slave/mem_alloc_slack_revocable_percent": 0,
  "slave/mem_alloc_slack_revocable_total": 1000,
  "slave/mem_alloc_slack_revocable_used": 0,


Thanks,

Guangya Liu

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/
---

(Updated Dec. 14, 2015, 7:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
---

Enabled slave get ALLOCATION_SLACK metrics.


Diffs (updated)
-

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41250/diff/


Testing
---

$ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
alloc_slack
  "slave/cpus_alloc_slack_revocable_percent": 0,
  "slave/cpus_alloc_slack_revocable_total": 3,
  "slave/cpus_alloc_slack_revocable_used": 0,
  "slave/disk_alloc_slack_revocable_percent": 0,
  "slave/disk_alloc_slack_revocable_total": 0,
  "slave/disk_alloc_slack_revocable_used": 0,
  "slave/mem_alloc_slack_revocable_percent": 0,
  "slave/mem_alloc_slack_revocable_total": 1000,
  "slave/mem_alloc_slack_revocable_used": 0,


Thanks,

Guangya Liu

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/
---

(Updated 十二月 12, 2015, 4:43 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
---

Enabled slave get ALLOCATION_SLACK metrics.


Diffs (updated)
-

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41250/diff/


Testing
---

$ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
alloc_slack
  "slave/cpus_alloc_slack_revocable_percent": 0,
  "slave/cpus_alloc_slack_revocable_total": 3,
  "slave/cpus_alloc_slack_revocable_used": 0,
  "slave/disk_alloc_slack_revocable_percent": 0,
  "slave/disk_alloc_slack_revocable_total": 0,
  "slave/disk_alloc_slack_revocable_used": 0,
  "slave/mem_alloc_slack_revocable_percent": 0,
  "slave/mem_alloc_slack_revocable_total": 1000,
  "slave/mem_alloc_slack_revocable_used": 0,


Thanks,

Guangya Liu

Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
---

Enabled slave get ALLOCATION_SLACK metrics.


Diffs
-

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 

Diff: https://reviews.apache.org/r/41250/diff/


Testing
---

$ curl "http://192.168.0.107:5051/metrics/snapshot; 2>/dev/null| jq . | grep 
alloc_slack
  "slave/cpus_alloc_slack_revocable_percent": 0,
  "slave/cpus_alloc_slack_revocable_total": 3,
  "slave/cpus_alloc_slack_revocable_used": 0,
  "slave/disk_alloc_slack_revocable_percent": 0,
  "slave/disk_alloc_slack_revocable_total": 0,
  "slave/disk_alloc_slack_revocable_used": 0,
  "slave/mem_alloc_slack_revocable_percent": 0,
  "slave/mem_alloc_slack_revocable_total": 1000,
  "slave/mem_alloc_slack_revocable_used": 0,


Thanks,

Guangya Liu