Re: Review Request 41854: Added module initialization to Master main().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review141561 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Feb. 13, 2016, 5:32 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41854/ > --- > > (Updated Feb. 13, 2016, 5:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Kapil Arya. > > > Bugs: MESOS-4253 > https://issues.apache.org/jira/browse/MESOS-4253 > > > Repository: mesos > > > Description > --- > > Added module initialization to Master main(). > > > Diffs > - > > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/41854/diff/ > > > Testing > --- > > make && make check > > [==] 932 tests from 119 test cases ran. (210502 ms total) > [ PASSED ] 932 tests. > > > Thanks, > > Marco Massenzio > >
Re: Review Request 41854: Added module initialization to Master main().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review121071 --- Ship it! Ship It! - Kapil Arya On Feb. 13, 2016, 12:32 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41854/ > --- > > (Updated Feb. 13, 2016, 12:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Kapil Arya. > > > Bugs: MESOS-4253 > https://issues.apache.org/jira/browse/MESOS-4253 > > > Repository: mesos > > > Description > --- > > Added module initialization to Master main(). > > > Diffs > - > > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/41854/diff/ > > > Testing > --- > > make && make check > > [==] 932 tests from 119 test cases ran. (210502 ms total) > [ PASSED ] 932 tests. > > > Thanks, > > Marco Massenzio > >
Re: Review Request 41854: Added module initialization to Master main().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 5:32 p.m.) Review request for mesos, Anand Mazumdar and Kapil Arya. Changes --- Added missing period to commit message. Summary (updated) - Added module initialization to Master main(). Bugs: MESOS-4253 https://issues.apache.org/jira/browse/MESOS-4253 Repository: mesos Description (updated) --- Added module initialization to Master main(). Diffs (updated) - src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing --- make && make check [==] 932 tests from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio
Re: Review Request 41854: Added module initialization to Master main().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review119158 --- Patch looks great! Reviews applied: [41760, 41854] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 13, 2016, 5:32 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41854/ > --- > > (Updated Feb. 13, 2016, 5:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Kapil Arya. > > > Bugs: MESOS-4253 > https://issues.apache.org/jira/browse/MESOS-4253 > > > Repository: mesos > > > Description > --- > > Added module initialization to Master main(). > > > Diffs > - > > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/41854/diff/ > > > Testing > --- > > make && make check > > [==] 932 tests from 119 test cases ran. (210502 ms total) > [ PASSED ] 932 tests. > > > Thanks, > > Marco Massenzio > >
Re: Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review119143 --- Bad patch! Reviews applied: [41760, 41854] Failed command: ./support/apply-review.sh -n -r 41854 Error: 2016-02-13 08:11:46 URL:https://reviews.apache.org/r/41854/diff/raw/ [2316/2316] -> "41854.patch" [1] Total errors found: 0 Checking 2 files Error: Commit message summary (the first line) must end in a period. Full log: https://builds.apache.org/job/mesos-reviewbot/11426/console - Mesos ReviewBot On Feb. 13, 2016, 7:02 a.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41854/ > --- > > (Updated Feb. 13, 2016, 7:02 a.m.) > > > Review request for mesos, Anand Mazumdar and Kapil Arya. > > > Bugs: MESOS-4253 > https://issues.apache.org/jira/browse/MESOS-4253 > > > Repository: mesos > > > Description > --- > > Added module initialization to Master main() method > > > Diffs > - > > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/41854/diff/ > > > Testing > --- > > make && make check > > [==] 932 tests from 119 test cases ran. (210502 ms total) > [ PASSED ] 932 tests. > > > Thanks, > > Marco Massenzio > >
Re: Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 6:32 a.m.) Review request for mesos, Anand Mazumdar and Kapil Arya. Changes --- Updated post-review (41760) changes. Note: for some reason the changes to src/slave/main.cpp are not picked up by this diff: this patch does NOT touch this file, it is exactly as it was in 41760. Bugs: MESOS-4253 https://issues.apache.org/jira/browse/MESOS-4253 Repository: mesos Description --- Added module initialization to Master main() method Diffs (updated) - src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing --- All unit tests pass. Thanks, Marco Massenzio
Re: Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 7:02 a.m.) Review request for mesos, Anand Mazumdar and Kapil Arya. Bugs: MESOS-4253 https://issues.apache.org/jira/browse/MESOS-4253 Repository: mesos Description --- Added module initialization to Master main() method Diffs (updated) - src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing --- make && make check [==] 932 tests from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio
Re: Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 6:59 a.m.) Review request for mesos, Anand Mazumdar and Kapil Arya. Changes --- fixed typo Bugs: MESOS-4253 https://issues.apache.org/jira/browse/MESOS-4253 Repository: mesos Description --- Added module initialization to Master main() method Diffs (updated) - src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing (updated) --- make && make check [==] 932 tests from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio
Re: Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review112448 --- Patch looks great! Reviews applied: [41760, 41854] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 3, 2016, 1:32 a.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41854/ > --- > > (Updated Jan. 3, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar and Kapil Arya. > > > Bugs: MESOS-4253 > https://issues.apache.org/jira/browse/MESOS-4253 > > > Repository: mesos > > > Description > --- > > Added module initialization to Master main() method > > > Diffs > - > > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 > > Diff: https://reviews.apache.org/r/41854/diff/ > > > Testing > --- > > All unit tests pass. > > > Thanks, > > Marco Massenzio > >
Review Request 41854: Added module initialization to Master main() method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- Review request for mesos, Anand Mazumdar and Kapil Arya. Bugs: MESOS-4253 https://issues.apache.org/jira/browse/MESOS-4253 Repository: mesos Description --- Added module initialization to Master main() method Diffs - src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 Diff: https://reviews.apache.org/r/41854/diff/ Testing --- All unit tests pass. Thanks, Marco Massenzio
