Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review115599
---

Ship it!


I'll also update the upgrades guide and CHANGELOG.

- Adam B


On Jan. 21, 2016, 1:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 21, 2016, 1:04 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 016ab65d60933cfe1dcd41e8afd6537abcd75171 
>   docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
>   src/master/flags.cpp 66c26be102229e24ae99f49292734db3cb83f17a 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review115595
---

Ship it!


Looks great!


docs/authorization.md (line 45)


s/can be teardown by/can be torn down by/


- Adam B


On Jan. 14, 2016, 12:06 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 14, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md a928f1722dc67cd791d78ebbe4591f2e8f2e8f2a 
>   docs/configuration.md 7e0eb9584f3cb24a388c44d7bc81cd87dbb4072e 
>   src/master/flags.cpp 88909590ff421421659e6faac7f3444bdc57b630 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/
---

(Updated 一月 21, 2016, 9:04 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

Updated document for teardown_frameworks.


Diffs (updated)
-

  docs/authorization.md 016ab65d60933cfe1dcd41e8afd6537abcd75171 
  docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
  src/master/flags.cpp 66c26be102229e24ae99f49292734db3cb83f17a 

Diff: https://reviews.apache.org/r/41979/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-14 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/
---

(Updated 一月 14, 2016, 8:06 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

Updated document for teardown_frameworks.


Diffs (updated)
-

  docs/authorization.md a928f1722dc67cd791d78ebbe4591f2e8f2e8f2a 
  docs/configuration.md 7e0eb9584f3cb24a388c44d7bc81cd87dbb4072e 
  src/master/flags.cpp 88909590ff421421659e6faac7f3444bdc57b630 

Diff: https://reviews.apache.org/r/41979/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review114452
---


Patch looks great!

Reviews applied: [41933, 41930, 41932, 41979]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 14, 2016, 8:06 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 14, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md a928f1722dc67cd791d78ebbe4591f2e8f2e8f2a 
>   docs/configuration.md 7e0eb9584f3cb24a388c44d7bc81cd87dbb4072e 
>   src/master/flags.cpp 88909590ff421421659e6faac7f3444bdc57b630 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-11 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review113695
---



docs/authorization.md (line 192)


Please don't create another nearly identical example. As current 
documentation, we should recommend using the newer names, and make no mention 
of the older names.



docs/configuration.md (line 273)


s/will be removed/is deprecated and will be removed/



docs/configuration.md (line 274)


s/recommonded/recommended/g



docs/configuration.md (line 297)


Only give an example for teardown_frameworks, since that's newer. We 
shouldn't be showing examples with a deprecated field. It's especially 
confusing to give an example that sets both.


- Adam B


On Jan. 6, 2016, 7:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 6, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 41979: Updated document for teardown_frameworks.

2016-01-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/
---

Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

Updated document for teardown_frameworks.


Diffs
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41979/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review113091
---


Patch looks great!

Reviews applied: [41933, 41930, 41932, 41979]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 3:23 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 6, 2016, 3:23 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>