Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 19, 2016, 8:22 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAvailable to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863 Diff: https://reviews.apache.org/r/42194/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 20, 2016, 6:42 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description (updated) --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using `updateAvailable` to unreserve some resources. Diffs - src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863 Diff: https://reviews.apache.org/r/42194/diff/ Testing (updated) --- make make check GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
> On 一月 14, 2016, 6:19 a.m., Klaus Ma wrote: > > If there is no much different with `updateAllocation`, I'd suggest to merge > > this patch with `updateAllocation`. The unit test is very different for those two APIs, so it is better keep them in two patches. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114429 --- On 一月 14, 2016, 12:46 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42194/ > --- > > (Updated 一月 14, 2016, 12:46 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > --- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This patch is halding the case when using updateAvailable to unreserve > some resources. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > d541bfa3f4190865c65d35c9d1ffdb8a3f194056 > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/42194/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 14, 2016, 12:46 p.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAvailable to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056 src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 Diff: https://reviews.apache.org/r/42194/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 14, 2016, 2:25 p.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAvailable to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056 src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 Diff: https://reviews.apache.org/r/42194/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 13, 2016, 1:10 p.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAvailable to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056 src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 Diff: https://reviews.apache.org/r/42194/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 13, 2016, 1:05 p.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Summary (updated) - Handle unreserve logic for dynamic reservation (3/3). Bugs: MESOS-4145 https://issues.apache.org/jira/browse/MESOS-4145 Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAvailable to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056 src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 Diff: https://reviews.apache.org/r/42194/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114429 --- If there is no much different with `updateAllocation`, I'd suggest to merge this patch with `updateAllocation`. - Klaus Ma On Jan. 13, 2016, 9:10 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42194/ > --- > > (Updated Jan. 13, 2016, 9:10 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > --- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This patch is halding the case when using updateAvailable to unreserve > some resources. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > d541bfa3f4190865c65d35c9d1ffdb8a3f194056 > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/42194/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
