Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-26 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/#review116326
---



Patch looks great!

Reviews applied: [42379, 42277, 42278]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 6:37 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42278/
> ---
> 
> (Updated Jan. 26, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Bugs: MESOS-4285
> https://issues.apache.org/jira/browse/MESOS-4285
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed volume paths for command tasks with image.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 496275a73601664b51155ef1373d8d46b9069613 
> 
> Diff: https://reviews.apache.org/r/42278/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-25 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/
---

(Updated Jan. 26, 2016, 6:37 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Bugs: MESOS-4285
https://issues.apache.org/jira/browse/MESOS-4285


Repository: mesos


Description
---

Fixed volume paths for command tasks with image.


Diffs (updated)
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
  src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
496275a73601664b51155ef1373d8d46b9069613 

Diff: https://reviews.apache.org/r/42278/diff/


Testing
---

make check


Thanks,

Timothy Chen



Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-15 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/
---

(Updated Jan. 16, 2016, 1:37 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Bugs: MESOS-4285
https://issues.apache.org/jira/browse/MESOS-4285


Repository: mesos


Description
---

Fixed volume paths for command tasks with image.


Diffs (updated)
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
  src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
f0c5b511ae20c720541351aba93f358ce26e0d51 

Diff: https://reviews.apache.org/r/42278/diff/


Testing
---

make check


Thanks,

Timothy Chen



Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-15 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/#review114841
---


Patch looks great!

Reviews applied: [42379, 42277, 42278]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 1:37 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42278/
> ---
> 
> (Updated Jan. 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Bugs: MESOS-4285
> https://issues.apache.org/jira/browse/MESOS-4285
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed volume paths for command tasks with image.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> f0c5b511ae20c720541351aba93f358ce26e0d51 
> 
> Diff: https://reviews.apache.org/r/42278/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-13 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/
---

(Updated Jan. 14, 2016, 12:15 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Bugs: MESOS-4285
https://issues.apache.org/jira/browse/MESOS-4285


Repository: mesos


Description
---

Fixed volume paths for command tasks with image.


Diffs
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
  src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 

Diff: https://reviews.apache.org/r/42278/diff/


Testing
---

make check


Thanks,

Timothy Chen



Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-13 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/
---

Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Fixed volume paths for command tasks with image.


Diffs
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
  src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 

Diff: https://reviews.apache.org/r/42278/diff/


Testing
---

make check


Thanks,

Timothy Chen