Re: Review Request 42524: Simplified SchedulerDriver.run().

[Kevin Klues]

> On Jan. 20, 2016, 1:40 a.m., Greg Mann wrote:
> > src/sched/sched.cpp, lines 1929-1930
> > 
> >
> > Since `join()` returns the current status anyway, could we just do 
> > `return join()`?

We could. I just thought it looked cleaner to make the calls unconditionally, 
followed by a return of the status.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42524/#review115308
---


On Jan. 19, 2016, 10:58 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42524/
> ---
> 
> (Updated Jan. 19, 2016, 10:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-4409
> https://issues.apache.org/jira/browse/MESOS-4409
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the status check in run() was unnecessary due to the short
> circuit path in join(). This commit simplifies run() by removing the
> check completely.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 38940b7e2563a2156be2f8c228afdc27c45b6e83 
> 
> Diff: https://reviews.apache.org/r/42524/diff/
> 
> 
> Testing
> ---
> 
> Ran the entire 'make check' suite with no failures on both Mac OS X and 
> ubuntu 14.04.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 42524: Simplified SchedulerDriver.run().

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42524/
---

Review request for mesos, Ben Mahler and Greg Mann.


Bugs: MESOS-4409
https://issues.apache.org/jira/browse/MESOS-4409


Repository: mesos


Description
---

Previously, the status check in run() was unnecessary due to the short
circuit path in join(). This commit simplifies run() by removing the
check completely.


Diffs
-

  src/sched/sched.cpp 38940b7e2563a2156be2f8c228afdc27c45b6e83 

Diff: https://reviews.apache.org/r/42524/diff/


Testing
---

Ran the entire 'make check' suite with no failures on both Mac OS X and ubuntu 
14.04.


Thanks,

Kevin Klues

Re: Review Request 42524: Simplified SchedulerDriver.run().

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42524/#review115308
---



src/sched/sched.cpp (lines 1929 - 1930)


Since `join()` returns the current status anyway, could we just do `return 
join()`?


- Greg Mann


On Jan. 19, 2016, 10:58 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42524/
> ---
> 
> (Updated Jan. 19, 2016, 10:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-4409
> https://issues.apache.org/jira/browse/MESOS-4409
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the status check in run() was unnecessary due to the short
> circuit path in join(). This commit simplifies run() by removing the
> check completely.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 38940b7e2563a2156be2f8c228afdc27c45b6e83 
> 
> Diff: https://reviews.apache.org/r/42524/diff/
> 
> 
> Testing
> ---
> 
> Ran the entire 'make check' suite with no failures on both Mac OS X and 
> ubuntu 14.04.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>