Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review118416 --- Ship it! Ship It! - Ben Mahler On Feb. 2, 2016, 10:28 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42633/ > --- > > (Updated Feb. 2, 2016, 10:28 a.m.) > > > Review request for mesos, Ben Mahler and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Revocable resources may come from different sources: usage slack (aka > oversubscribed resources), allocation slack (aka optimistic offers). > We should not use "oversubscribed" and "revocable" interchangeably. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 1f0c440565ee0f9926d168734df30fd740a53f88 > > Diff: https://reviews.apache.org/r/42633/diff/ > > > Testing > --- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- (Updated Feb. 2, 2016, 10:28 a.m.) Review request for mesos, Ben Mahler and Qian Zhang. Repository: mesos Description --- Revocable resources may come from different sources: usage slack (aka oversubscribed resources), allocation slack (aka optimistic offers). We should not use "oversubscribed" and "revocable" interchangeably. Diffs - src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88 Diff: https://reviews.apache.org/r/42633/diff/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov
Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- (Updated Jan. 28, 2016, 1:07 p.m.) Review request for mesos, Ben Mahler and Qian Zhang. Changes --- Rebased. Repository: mesos Description --- Revocable resources may come from different sources: usage slack (aka oversubscribed resources), allocation slack (aka optimistic offers). We should not use "oversubscribed" and "revocable" interchangeably. Diffs (updated) - src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88 Diff: https://reviews.apache.org/r/42633/diff/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov
Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review115807 --- Why did you make this change? - Ben Mahler On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42633/ > --- > > (Updated Jan. 22, 2016, 1:24 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 18f77bcf596c2ee17b4e407fac4367b0c737ce82 > > Diff: https://reviews.apache.org/r/42633/diff/ > > > Testing > --- > > None > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 42633: Corrected a comment in the allocator.
> On Jan. 22, 2016, 4:16 p.m., Ben Mahler wrote: > > Why did you make this change? I think the main reason should be, after optimistic offer phase 1 is done, we will have two types of revocable resource: usage slack (oversubscription resources) and allocation slack. - Qian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review115807 --- On Jan. 22, 2016, 9:24 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42633/ > --- > > (Updated Jan. 22, 2016, 9:24 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 18f77bcf596c2ee17b4e407fac4367b0c737ce82 > > Diff: https://reviews.apache.org/r/42633/diff/ > > > Testing > --- > > None > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- (Updated Jan. 22, 2016, 12:43 p.m.) Review request for mesos, Ben Mahler and Qian Zhang. Repository: mesos Description (updated) --- Revocable resources may come from different sources: usage slack (aka oversubscribed resources), allocation slack (aka optimistic offers). We should not use "oversubscribed" and "revocable" interchangeably. Diffs (updated) - src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c Diff: https://reviews.apache.org/r/42633/diff/ Testing (updated) --- None: not a functional change. Thanks, Alexander Rukletsov
Re: Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review115760 --- Ship it! Ship It! - Guangya Liu On 一月 22, 2016, 1:24 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42633/ > --- > > (Updated 一月 22, 2016, 1:24 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > 18f77bcf596c2ee17b4e407fac4367b0c737ce82 > > Diff: https://reviews.apache.org/r/42633/diff/ > > > Testing > --- > > None > > > Thanks, > > Alexander Rukletsov > >
Review Request 42633: Corrected a comment in the allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --- See summary. Diffs - src/master/allocator/mesos/hierarchical.hpp 18f77bcf596c2ee17b4e407fac4367b0c737ce82 Diff: https://reviews.apache.org/r/42633/diff/ Testing --- None Thanks, Alexander Rukletsov
