Re: Review Request 42792: Fix compile error in container logger tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116333 --- Ship it! Ship It! - Klaus Ma On Jan. 26, 2016, 4:12 p.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > --- > > (Updated Jan. 26, 2016, 4:12 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4508 > https://issues.apache.org/jira/browse/MESOS-4508 > > > Repository: mesos > > > Description > --- > > Use unsigned value when comparing with kilobytes. > > > Diffs > - > > src/tests/container_logger_tests.cpp > ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 > > Diff: https://reviews.apache.org/r/42792/diff/ > > > Testing > --- > > make check on OSX and Ubuntu 15.04 > > > Thanks, > > Jian Qiu > >
Review Request 42792: Fix compile error in container logger tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4508 https://issues.apache.org/jira/browse/MESOS-4508 Repository: mesos Description --- Use unsigned value when comparing with kilobytes. Diffs - src/tests/container_logger_tests.cpp ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 Diff: https://reviews.apache.org/r/42792/diff/ Testing --- make check on OSX and Ubuntu 15.04 Thanks, Jian Qiu
Re: Review Request 42792: Fix compile error in container logger tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116350 --- Patch looks great! Reviews applied: [42792] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 26, 2016, 8:12 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > --- > > (Updated Jan. 26, 2016, 8:12 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4508 > https://issues.apache.org/jira/browse/MESOS-4508 > > > Repository: mesos > > > Description > --- > > Use unsigned value when comparing with kilobytes. > > > Diffs > - > > src/tests/container_logger_tests.cpp > ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 > > Diff: https://reviews.apache.org/r/42792/diff/ > > > Testing > --- > > make check on OSX and Ubuntu 15.04 > > > Thanks, > > Jian Qiu > >
Re: Review Request 42792: Fix compile error in container logger tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116427 --- Sorry about that. Till already committed an identical patch. https://reviews.apache.org/r/42803/ - Joseph Wu On Jan. 26, 2016, 12:12 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > --- > > (Updated Jan. 26, 2016, 12:12 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4508 > https://issues.apache.org/jira/browse/MESOS-4508 > > > Repository: mesos > > > Description > --- > > Use unsigned value when comparing with kilobytes. > > > Diffs > - > > src/tests/container_logger_tests.cpp > ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 > > Diff: https://reviews.apache.org/r/42792/diff/ > > > Testing > --- > > make check on OSX and Ubuntu 15.04 > > > Thanks, > > Jian Qiu > >
Re: Review Request 42792: Fix compile error in container logger tests.
> On 一月 26, 2016, 7:33 p.m., Joseph Wu wrote: > > Sorry about that. Till already committed an identical patch. > > https://reviews.apache.org/r/42803/ Thanks for doing this. There is also a race in DefaultToSandbox when it runs on ubuntu. Sometimes it cannot read string from stdout. We may need to wait until task finished. Mind taking a look at it? - Jian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116427 --- On 一月 26, 2016, 8:12 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > --- > > (Updated 一月 26, 2016, 8:12 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4508 > https://issues.apache.org/jira/browse/MESOS-4508 > > > Repository: mesos > > > Description > --- > > Use unsigned value when comparing with kilobytes. > > > Diffs > - > > src/tests/container_logger_tests.cpp > ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 > > Diff: https://reviews.apache.org/r/42792/diff/ > > > Testing > --- > > make check on OSX and Ubuntu 15.04 > > > Thanks, > > Jian Qiu > >
Re: Review Request 42792: Fix compile error in container logger tests.
> On Jan. 26, 2016, 11:33 a.m., Joseph Wu wrote: > > Sorry about that. Till already committed an identical patch. > > https://reviews.apache.org/r/42803/ > > Jian Qiu wrote: > Thanks for doing this. There is also a race in DefaultToSandbox when it > runs on ubuntu. Sometimes it cannot read string from stdout. We may need to > wait until task finished. Mind taking a look at it? Sure. Here's the patch, in case its blocking you: https://reviews.apache.org/r/42842/ - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116427 --- On Jan. 26, 2016, 12:12 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42792/ > --- > > (Updated Jan. 26, 2016, 12:12 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4508 > https://issues.apache.org/jira/browse/MESOS-4508 > > > Repository: mesos > > > Description > --- > > Use unsigned value when comparing with kilobytes. > > > Diffs > - > > src/tests/container_logger_tests.cpp > ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 > > Diff: https://reviews.apache.org/r/42792/diff/ > > > Testing > --- > > make check on OSX and Ubuntu 15.04 > > > Thanks, > > Jian Qiu > >
