Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/#review118135 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 10:27 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43107/ > --- > > (Updated Feb. 5, 2016, 10:27 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4344 > https://issues.apache.org/jira/browse/MESOS-4344 > > > Repository: mesos > > > Description > --- > > The `cgroup/net_cls` isolator will use the primary handle, passed by the > operator using the --cgroup_net_cls_primary_handle, to initialize the > `NetClsHandleManager`. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > f96c3274610269eacc9e91fec21a47a06bfeea62 > > Diff: https://reviews.apache.org/r/43107/diff/ > > > Testing > --- > > make and make check > > Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle > and made sure the slave correctly detects these invalid handles. > > Launched a slave with valid handle to make sure that the slave launches > correctly. > > > Thanks, > > Avinash sridharan > >
Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 5, 2016, 10:27 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description --- The `cgroup/net_cls` isolator will use the primary handle, passed by the operator using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleManager`. Diffs (updated) - src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f96c3274610269eacc9e91fec21a47a06bfeea62 Diff: https://reviews.apache.org/r/43107/diff/ Testing --- make and make check Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan
Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 5, 2016, 3:34 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description --- The `cgroup/net_cls` isolator will use the primary handle, passed by the operator using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleManager`. Diffs (updated) - src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp bf6c88341dedc0a37546c04f38197c892b498684 Diff: https://reviews.apache.org/r/43107/diff/ Testing --- make and make check Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan
Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 4, 2016, 1:52 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description (updated) --- The `cgroup/net_cls` isolator will use the primary handle, passed by the operator using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleManager`. Diffs (updated) - src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/43107/diff/ Testing --- make and make check Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan
Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 3, 2016, 12:52 a.m.) Review request for mesos and Jie Yu. Changes --- Rebased. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description --- The `cgroup/net_cls` isolator will use the primary handle, passed by the operator using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleMgr`. Diffs (updated) - src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/43107/diff/ Testing --- make and make check Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan
Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description --- The `cgroup/net_cls` isolator will use the primary handle, passed by the operator using the --cgroup_net_cls_primary_handle, to initialize the `NetClsHandleMgr`. Diffs - src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/43107/diff/ Testing --- make and make check Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan
