Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

[Neil Conway]

> On Feb. 23, 2016, 6:17 p.m., Ben Mahler wrote:
> > support/generate-endpoint-help.py, line 316
> > 
> >
> > How about on_exit?

Sounds good.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review120350
---


On Feb. 19, 2016, 7:21 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> ---
> 
> (Updated Feb. 19, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the script exited when `current_subprocess` was None, it would
> print an ugly exception stack trace.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43384/diff/
> 
> 
> Testing
> ---
> 
> Ran the script in error and non-error cases with the changes applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review120350
---


Ship it!





support/generate-endpoint-help.py (line 316)


How about on_exit?


- Ben Mahler


On Feb. 19, 2016, 7:21 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> ---
> 
> (Updated Feb. 19, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the script exited when `current_subprocess` was None, it would
> print an ugly exception stack trace.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43384/diff/
> 
> 
> Testing
> ---
> 
> Ran the script in error and non-error cases with the changes applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/
---

(Updated Feb. 19, 2016, 7:21 p.m.)


Review request for mesos, Ben Mahler and Kevin Klues.


Changes
---

Revised per Kevin's comments.


Summary (updated)
-

Fixed minor bug in generate-endpoint-help.py.


Repository: mesos


Description (updated)
---

If the script exited when `current_subprocess` was None, it would
print an ugly exception stack trace.


Diffs (updated)
-

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43384/diff/


Testing
---

Ran the script in error and non-error cases with the changes applied.


Thanks,

Neil Conway