Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/#review141547
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 17, 2016, 3:01 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43593/
> ---
> 
> (Updated Feb. 17, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
> https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add test for spliting revocable resources in separate offer.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43593/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>



Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/#review119424
---



Patch looks great!

Reviews applied: [43041, 43593]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 3:01 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43593/
> ---
> 
> (Updated Feb. 17, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
> https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add test for spliting revocable resources in separate offer.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43593/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>



Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/
---

(Updated Feb. 17, 2016, 3:01 a.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Remove the duplicate check.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Add test for spliting revocable resources in separate offer.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43593/diff/


Testing
---

Make && Make check.


Thanks,

Yongqiao Wang



Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/
---

(Updated Feb. 16, 2016, 12:02 p.m.)


Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Add test for spliting revocable resources in separate offer.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43593/diff/


Testing
---

Make && Make check.


Thanks,

Yongqiao Wang



Review Request 43593: Add test for spliting revocable resources in separate offer.

2016-02-16 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43593/
---

Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
Jian Qiu, and Vinod Kone.


Bugs: MESOS-2646
https://issues.apache.org/jira/browse/MESOS-2646


Repository: mesos


Description
---

Add test for spliting revocable resources in separate offer.


Diffs
-

  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43593/diff/


Testing
---

Make && Make check.


Thanks,

Yongqiao Wang