Re: Review Request 43758: Made signal escalation timeout configurable in command executor.

2016-03-09 Thread Alexander Rukletsov 


> On Feb. 19, 2016, 1:23 p.m., Guangya Liu wrote:
> > src/launcher/executor.cpp, lines 173-174
> > 
> >
> > Add some checking here if the `escalationTimeout < Duration::zero()`?

Good point. Indeed, we theoretically allow `stout::Duration` and `DurationInfo` 
to be negative, so a check is necessary.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43758/#review119873
---


On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43758/
> ---
> 
> (Updated Feb. 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43758/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 43758: Made signal escalation timeout configurable in command executor.

2016-02-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43758/#review119873
---




src/launcher/executor.cpp (lines 173 - 174)


Add some checking here if the `escalationTimeout < Duration::zero()`?


- Guangya Liu


On 二月 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43758/
> ---
> 
> (Updated 二月 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43758/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 43758: Made signal escalation timeout configurable in command executor.

2016-02-19 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43758/
---

Review request for mesos, Anand Mazumdar and Ben Mahler.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs
-

  src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 

Diff: https://reviews.apache.org/r/43758/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/43764/ .


Thanks,

Alexander Rukletsov