Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120592
---



Patch looks great!

Reviews applied: [43776, 43777, 43782, 43778, 43779, 43800]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 24, 2016, 6:43 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> ---
> 
> (Updated Feb. 24, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization docs for '/reserve' and '/create-volumes'.
> 
> This updates the authorization documentation to include the new `roles` 
> object for the `CreateVolume` and `ReserveResources` ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-24 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/
---

(Updated Feb. 24, 2016, 6:43 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Updated authorization docs for '/reserve' and '/create-volumes'.

This updates the authorization documentation to include the new `roles` object 
for the `CreateVolume` and `ReserveResources` ACLs.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 

Diff: https://reviews.apache.org/r/43800/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/
---

(Updated Feb. 22, 2016, 7:59 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Addressed comments, added new ACL examples.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Updated authorization docs for '/reserve' and '/create-volumes'.

This updates the authorization documentation to include the new `roles` object 
for the `CreateVolume` and `ReserveResources` ACLs.


Diffs (updated)
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 

Diff: https://reviews.apache.org/r/43800/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120037
---



Patch looks great!

Reviews applied: [43776, 43777, 43782, 43778, 43779, 43800]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 20, 2016, 1:32 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> ---
> 
> (Updated Feb. 20, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization docs for '/reserve' and '/create-volumes'.
> 
> This updates the authorization documentation to include the new `roles` 
> object for the `CreateVolume` and `ReserveResources` ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-20 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120031
---




docs/authorization.md (lines 215 - 244)


Can you please also add an example of `reserve_resources` with some 
specified roles?



docs/authorization.md (line 285)


What about adding another two examples for `create_volumes` with `"type" : 
"None"` and specified `roles`?


- Guangya Liu


On 二月 20, 2016, 1:32 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> ---
> 
> (Updated 二月 20, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization docs for '/reserve' and '/create-volumes'.
> 
> This updates the authorization documentation to include the new `roles` 
> object for the `CreateVolume` and `ReserveResources` ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/#review120027
---




docs/authorization.md (lines 37 - 48)


Some sentence has period while others not, can you please unify this? I 
think that we should add period for all of those sentence to the end.


- Guangya Liu


On 二月 20, 2016, 1:32 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43800/
> ---
> 
> (Updated 二月 20, 2016, 1:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-4591
> https://issues.apache.org/jira/browse/MESOS-4591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization docs for '/reserve' and '/create-volumes'.
> 
> This updates the authorization documentation to include the new `roles` 
> object for the `CreateVolume` and `ReserveResources` ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
> 
> Diff: https://reviews.apache.org/r/43800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43800/
---

Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
---

Updated authorization docs for '/reserve' and '/create-volumes'.

This updates the authorization documentation to include the new `roles` object 
for the `CreateVolume` and `ReserveResources` ACLs.


Diffs
-

  docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 

Diff: https://reviews.apache.org/r/43800/diff/


Testing
---


Thanks,

Greg Mann