Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-23 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/#review120340
---



Did you test this? ;)

We need to also adjust slave.html and the javascript code, let's discard this 
since I already have a working patch.

- Ben Mahler


On Feb. 22, 2016, 10:18 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43827/
> ---
> 
> (Updated Feb. 22, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introducing TASK_KILLING state on WebUI.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 
> 
> Diff: https://reviews.apache.org/r/43827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/#review120175
---



Patch looks great!

Reviews applied: [43487, 43488, 43489, 43490, 43827]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 10:18 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43827/
> ---
> 
> (Updated Feb. 22, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introducing TASK_KILLING state on WebUI.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 
> 
> Diff: https://reviews.apache.org/r/43827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

(Updated Feb. 22, 2016, 10:18 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta



Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

(Updated Feb. 22, 2016, 10:17 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4547
https://issues.apache.org/jira/browse/MESOS-4547


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta



Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43827/
---

Review request for mesos.


Repository: mesos


Description
---

Introducing TASK_KILLING state on WebUI.


Diffs
-

  src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 

Diff: https://reviews.apache.org/r/43827/diff/


Testing
---


Thanks,

Abhishek Dasgupta