Re: Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44008/#review141553
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 25, 2016, 3:29 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44008/
> ---
> 
> (Updated Feb. 25, 2016, 3:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4773
> https://issues.apache.org/jira/browse/MESOS-4773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Top CMakeLists-add master to cmake module path.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 
> 
> Diff: https://reviews.apache.org/r/44008/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>



Re: Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.

2016-02-25 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44008/#review120754
---



Patch looks great!

Reviews applied: [43997, 44001, 44003, 44005, 44007, 44008]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 25, 2016, 3:29 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44008/
> ---
> 
> (Updated Feb. 25, 2016, 3:29 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4773
> https://issues.apache.org/jira/browse/MESOS-4773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Top CMakeLists-add master to cmake module path.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 
> 
> Diff: https://reviews.apache.org/r/44008/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>



Review Request 44008: CMake: Top CMakeLists-add master to cmake module path.

2016-02-25 Thread Diana Arroyo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44008/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-4773
https://issues.apache.org/jira/browse/MESOS-4773


Repository: mesos


Description
---

CMake: Top CMakeLists-add master to cmake module path.


Diffs
-

  CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 

Diff: https://reviews.apache.org/r/44008/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo