Re: Review Request 44071: Added documentation for new libprocess environment variable.

2016-03-02 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44071/#review121779
---


Ship it!





docs/configuration.md (lines 1694 - 1700)


The comments above are indented by 2 more than this block..?

How about:

```
  

  LIBPROCESS_METRICS_SNAPSHOT_ENDPOINT_RATE_LIMIT


  If set, this variable can be used to configure the rate limit
  applied to the /metrics/snapshot endpoint. The format is
  `/`.
  Examples: `10/1secs`, `100/10secs`, etc.

  
```


- Ben Mahler


On March 1, 2016, 9:04 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44071/
> ---
> 
> (Updated March 1, 2016, 9:04 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Ben 
> Mahler.
> 
> 
> Bugs: MESOS-4776
> https://issues.apache.org/jira/browse/MESOS-4776
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The environment variable LIBPROCESS_METRICS_ENDPOINT_RATE_LIMIT was
> added in a previous commit; add the corresponding documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
> 
> Diff: https://reviews.apache.org/r/44071/diff/
> 
> 
> Testing
> ---
> 
> Site rendered with packaged docker container.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44071: Added documentation for new libprocess environment variable.

2016-03-01 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44071/
---

(Updated March 1, 2016, 10:04 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Ben Mahler.


Changes
---

Updated for changed env var semantics.


Summary (updated)
-

Added documentation for new libprocess environment variable.


Bugs: MESOS-4776
https://issues.apache.org/jira/browse/MESOS-4776


Repository: mesos


Description (updated)
---

The environment variable LIBPROCESS_METRICS_ENDPOINT_RATE_LIMIT was
added in a previous commit; add the corresponding documentation.


Diffs (updated)
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 

Diff: https://reviews.apache.org/r/44071/diff/


Testing
---

Site rendered with packaged docker container.


Thanks,

Benjamin Bannier