Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44499/
---

(Updated June 14, 2016, 1:04 a.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4781
https://issues.apache.org/jira/browse/MESOS-4781


Repository: mesos


Description
---

Added task_environment flag/used execvpe for command executor.


Diffs (updated)
-

  src/launcher/executor.cpp ffebb3a496be6a20396f8f539372a1e7527c9b6d 

Diff: https://reviews.apache.org/r/44499/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44499/#review125506
---




src/launcher/executor.cpp (line 311)


Just a question here: Does the os::raw::environment() will be overwritten 
by taskEnvironment? What is the use of `os::raw::environment()` here?


- Guangya Liu


On 三月 24, 2016, 9:53 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44499/
> ---
> 
> (Updated 三月 24, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4781
> https://issues.apache.org/jira/browse/MESOS-4781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added task_environment flag/used execvpe for command executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
> 
> Diff: https://reviews.apache.org/r/44499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

[Gilbert Song]

> On March 16, 2016, 4:22 a.m., Benjamin Bannier wrote:
> > src/launcher/executor.cpp, lines 470-471
> > 
> >
> > Any reason we cannot use the `CHECK` condition for the `if`?

Thanks, Benjamin! We do not always have taskEnvironment passed form runtime 
isolator, so it is not always ture.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44499/#review123854
---


On March 24, 2016, 2:53 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44499/
> ---
> 
> (Updated March 24, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4781
> https://issues.apache.org/jira/browse/MESOS-4781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added task_environment flag/used execvpe for command executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
> 
> Diff: https://reviews.apache.org/r/44499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44499: Added task_environment flag/used execvpe for command executor.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44499/
---

(Updated March 24, 2016, 2:53 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-4781
https://issues.apache.org/jira/browse/MESOS-4781


Repository: mesos


Description
---

Added task_environment flag/used execvpe for command executor.


Diffs (updated)
-

  src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 

Diff: https://reviews.apache.org/r/44499/diff/


Testing
---

make check


Thanks,

Gilbert Song