Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

[Ashwin Murthy]

Thanks!

On Fri, Mar 25, 2016 at 10:18 AM, Vinod Kone  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45000/
>
> Ship it!
>
> Thanks for following up with a real test!
>
> Btw, no need for that NOTE as the bug is attached to this review and the 
> commit will be pasted to that ticket. I'll remove it while committing.
>
>
> - Vinod Kone
>
> On March 24th, 2016, 2:24 a.m. UTC, Ashwin Murthy wrote:
> Review request for mesos and Vinod Kone.
> By Ashwin Murthy.
>
> *Updated March 24, 2016, 2:24 a.m.*
> *Repository: * mesos
> Description
>
> MESOS-3902: [Final] Fix location header in redirect from non-leader. Fixed to 
> append the path from the original URL.
>
> Testing
>
> This has been tested end to end with 3 local mesos masters and zk. Valided 
> the location header is now correct.
>
> Diffs
>
>- src/master/http.cpp (97e4b0ce3286540788e3e6c5b484687b83e000f6)
>
> View Diff 
>

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45000/#review125434
---


Ship it!




Thanks for following up with a real test!

Btw, no need for that NOTE as the bug is attached to this review and the commit 
will be pasted to that ticket. I'll remove it while committing.

- Vinod Kone


On March 24, 2016, 2:24 a.m., Ashwin Murthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45000/
> ---
> 
> (Updated March 24, 2016, 2:24 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3902: [Final] Fix location header in redirect from non-leader. Fixed to 
> append the path from the original URL.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 97e4b0ce3286540788e3e6c5b484687b83e000f6 
> 
> Diff: https://reviews.apache.org/r/45000/diff/
> 
> 
> Testing
> ---
> 
> This has been tested end to end with 3 local mesos masters and zk. Valided 
> the location header is now correct.
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

[Ashwin Murthy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45000/
---

(Updated March 24, 2016, 2:24 a.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-

MESOS-3902: [Updated] Fix location header in redirect from non-leader.


Repository: mesos


Description (updated)
---

MESOS-3902: [Final] Fix location header in redirect from non-leader. Fixed to 
append the path from the original URL.


Diffs (updated)
-

  src/master/http.cpp 97e4b0ce3286540788e3e6c5b484687b83e000f6 

Diff: https://reviews.apache.org/r/45000/diff/


Testing (updated)
---

This has been tested end to end with 3 local mesos masters and zk. Valided the 
location header is now correct.


Thanks,

Ashwin Murthy