Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-25 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/
---

(Updated March 26, 2016, 12:25 a.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Rebase.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated docs for deletion of persistent volumes.


Diffs (updated)
-

  docs/multiple-disk.md 5cdce26721212597052515a9cf2fd9277d24e42c 
  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md 1b683b59b981ec7e4664c751cb57ab848c7506dc 

Diff: https://reviews.apache.org/r/45123/diff/


Testing
---


Thanks,

Neil Conway



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/
---

(Updated March 22, 2016, 11:02 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Rebase, update storage-management discussion in multi-disk doc.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated docs for deletion of persistent volumes.


Diffs (updated)
-

  docs/multiple-disk.md 5cdce26721212597052515a9cf2fd9277d24e42c 
  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md f8bd8a2fcf1b38eaed1bd77e8a9dd3e3370008e5 

Diff: https://reviews.apache.org/r/45123/diff/


Testing
---


Thanks,

Neil Conway



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Neil Conway


> On March 22, 2016, 7:58 a.m., Guangya Liu wrote:
> > What about 
> > https://github.com/apache/mesos/blob/master/docs/multiple-disk.md#storage-management
> >  ? I think that we should also update here as well.

Good catch! Thanks, fixed.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/#review124752
---


On March 22, 2016, 6:24 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45123/
> ---
> 
> (Updated March 22, 2016, 6:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
> 
> Diff: https://reviews.apache.org/r/45123/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/#review124810
---



Patch looks great!

Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 
42593, 42505, 42506, 42684, 45117, 45118, 45119, 45120, 45121, 45122, 45123]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 22, 2016, 6:24 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45123/
> ---
> 
> (Updated March 22, 2016, 6:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
> 
> Diff: https://reviews.apache.org/r/45123/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/#review124752
---



What about 
https://github.com/apache/mesos/blob/master/docs/multiple-disk.md#storage-management
 ? I think that we should also update here as well.

- Guangya Liu


On 三月 22, 2016, 6:24 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45123/
> ---
> 
> (Updated 三月 22, 2016, 6:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
> 
> Diff: https://reviews.apache.org/r/45123/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/
---

(Updated March 22, 2016, 6:24 a.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Tweak docs.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated docs for deletion of persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
  docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
  docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 

Diff: https://reviews.apache.org/r/45123/diff/


Testing
---


Thanks,

Neil Conway



Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45123/#review124672
---



Patch looks great!

Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 
42593, 42505, 42506, 42684, 45117, 45118, 45119, 45120, 45121, 45122, 45123]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45123/
> ---
> 
> (Updated March 21, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
> 
> Diff: https://reviews.apache.org/r/45123/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>