Re: Review Request 45185: Introduced an agent flag 'system_config_files'.

2016-03-24 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45185/#review125289
---




src/slave/flags.cpp (line 108)


I think we should also mention this only applies when image provisioner is 
enabled and used.


- Timothy Chen


On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45185/
> ---
> 
> (Updated March 23, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
> https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced an agent flag 'system_config_files'.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 73ee8fa7a77a6ceaf44e1f4c54ab4027a7109258 
>   src/slave/flags.hpp 3067c128f1fded4f130f4d45f191584c2f30ad9c 
>   src/slave/flags.cpp ce028825ad99f54a231b4b18dde277b63aa0525c 
> 
> Diff: https://reviews.apache.org/r/45185/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Review Request 45185: Introduced an agent flag 'system_config_files'.

2016-03-22 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45185/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Bugs: MESOS-3003
https://issues.apache.org/jira/browse/MESOS-3003


Repository: mesos


Description
---

Introduced an agent flag 'system_config_files'.


Diffs
-

  docs/configuration.md 73ee8fa7a77a6ceaf44e1f4c54ab4027a7109258 
  src/slave/flags.hpp 3067c128f1fded4f130f4d45f191584c2f30ad9c 
  src/slave/flags.cpp ce028825ad99f54a231b4b18dde277b63aa0525c 

Diff: https://reviews.apache.org/r/45185/diff/


Testing
---

make check


Thanks,

Gilbert Song