Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128913
---


Ship it!




Ship It!

- Jie Yu


On April 14, 2016, 4:37 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 14, 2016, 4:37 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 四月 14, 2016, 4:37 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs (updated)
-

  include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
  include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 

Diff: https://reviews.apache.org/r/45214/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread Guangya Liu 


> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto, line 1625
> > 
> >
> > I definitely prefer this form, but there's also a Parameters message 
> > type. Which is more idiomatic in this context?
> 
> Guangya Liu wrote:
> I saw that no one in protobuf is using this, and the `Parameters` is just 
> a wrapper of `repeated Parameter parameter`, I think it is OK to use 
> `repeated Parameter parameter` here, comments?

Thanks James, I did some test and found that `Parameters` is more easy to use, 
will update this patch soon.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
---


On 四月 13, 2016, 3:09 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated 四月 13, 2016, 3:09 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread Guangya Liu 


> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto, line 1625
> > 
> >
> > I definitely prefer this form, but there's also a Parameters message 
> > type. Which is more idiomatic in this context?

I saw that no one in protobuf is using this, and the `Parameters` is just a 
wrapper of `repeated Parameter parameter`, I think it is OK to use `repeated 
Parameter parameter` here, comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
---


On 四月 13, 2016, 3:09 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated 四月 13, 2016, 3:09 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread James DeFelice 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
---




include/mesos/mesos.proto (line 1625)


I definitely prefer this form, but there's also a Parameters message type. 
Which is more idiomatic in this context?


- James DeFelice


On April 13, 2016, 3:09 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 13, 2016, 3:09 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 四月 13, 2016, 3:09 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs (updated)
-

  include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
  include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 

Diff: https://reviews.apache.org/r/45214/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review127155
---




include/mesos/mesos.proto (line 1604)


How about use `repeated Parameter` as type here?


- haosdent huang


On April 4, 2016, 8:39 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 4, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-04 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126983
---




include/mesos/mesos.proto (line 1563)


We cannot simply do that change. That'll make the rollback impossible. This 
needs to go through a deprecation cycle.


- Jie Yu


On April 4, 2016, 8:39 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 4, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-04 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126791
---



Ditto to the v1. Thanks, Guangya!


include/mesos/mesos.proto (line 1563)


+1.



include/mesos/mesos.proto (line 1576)


Let's make it 0.30.



include/mesos/mesos.proto (line 1581)


ditto.



include/mesos/mesos.proto (lines 1597 - 1600)


Would we possibly have more fields in this message? If no, I guess we may 
want `repeated string driver_option = 3` only below.

BTW, if we want to keep this msg, could we clarify more detail in comment 
(e.g., add an example in \'\')?



include/mesos/mesos.proto (line 1605)


Newline above.



include/mesos/mesos.proto (line 1607)


ditto.


- Gilbert Song


On April 1, 2016, 10:41 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> ---
> 
> (Updated April 1, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
>   include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-01 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 四月 2, 2016, 5:41 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs
-

  include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
  include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 

Diff: https://reviews.apache.org/r/45214/diff/


Testing (updated)
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45214: Updated protobuf to support external storage.

2016-03-25 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 三月 25, 2016, 2:07 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs (updated)
-

  include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 
  include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f 

Diff: https://reviews.apache.org/r/45214/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 45214: Updated protobuf to support external storage.

2016-03-23 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 三月 24, 2016, 2:24 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs (updated)
-

  include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
  include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 

Diff: https://reviews.apache.org/r/45214/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 45214: Updated protobuf to support external storage.

2016-03-23 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
---

(Updated 三月 23, 2016, 1:30 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012


Repository: mesos


Description
---

Updated protobuf to support external storage.


Diffs (updated)
-

  include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
  include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 

Diff: https://reviews.apache.org/r/45214/diff/


Testing
---


Thanks,

Guangya Liu