Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/#review125611
---



Oops. Found a bug!


src/tests/files_tests.cpp (line 81)


Don't you need to call `TemporaryDirectoryTest::TearDown();` at the end of 
this?


- Adam B


On March 25, 2016, 5:07 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45249/
> ---
> 
> (Updated March 25, 2016, 5:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.
> 
> 
> Bugs: MESOS-4956
> https://issues.apache.org/jira/browse/MESOS-4956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new test was added (FilesTest.AuthenticationTest) to probe the `/files/*` 
> endpoints' behavior when HTTP authentication is enabled.
> 
> 
> Diffs
> -
> 
>   src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 
> 
> Diff: https://reviews.apache.org/r/45249/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` and `GTEST_FILTER="FilesTest.AuthenticationTest" 
> build/bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` were 
> used to test on OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/#review125606
---


Fix it, then Ship it!




Thanks! I'll move the namespace= and indent those EXPECT params, then commit it


src/tests/files_tests.cpp (line 51)


namespace= declarations always seem to go above the using's, right after 
includes.



src/tests/files_tests.cpp (line 357)


Not sure why this needed to be its own function if it's only used once. 
Maybe you anticipate more tests using it in the future?



src/tests/files_tests.cpp (line 375)


Let's align this with `response`, since that won't create too much 
jaggedness. Otherwise, we'd prefer each parameter get its own line.


- Adam B


On March 25, 2016, 5:07 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45249/
> ---
> 
> (Updated March 25, 2016, 5:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.
> 
> 
> Bugs: MESOS-4956
> https://issues.apache.org/jira/browse/MESOS-4956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new test was added (FilesTest.AuthenticationTest) to probe the `/files/*` 
> endpoints' behavior when HTTP authentication is enabled.
> 
> 
> Diffs
> -
> 
>   src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 
> 
> Diff: https://reviews.apache.org/r/45249/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` and `GTEST_FILTER="FilesTest.AuthenticationTest" 
> build/bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` were 
> used to test on OSX and CentOS 7.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/
---

(Updated March 25, 2016, 4:42 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.


Bugs: MESOS-4956
https://issues.apache.org/jira/browse/MESOS-4956


Repository: mesos


Description (updated)
---

A new test was added (FilesTest.AuthenticationTest) to probe the `/files/*` 
endpoints' behavior when HTTP authentication is enabled.


Diffs (updated)
-

  src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 

Diff: https://reviews.apache.org/r/45249/diff/


Testing (updated)
---

`sudo make check` and `GTEST_FILTER="FilesTest.AuthenticationTest" 
build/bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` were 
used to test on OSX and CentOS 7.


Thanks,

Greg Mann

Re: Review Request 45249: Added a new '/files' endpoints test using authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45249/
---

(Updated March 24, 2016, 11:59 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.


Changes
---

Removed the RAII wrapper :-) Manage the authenticator lifecycle in the test 
fixture setup/teardown.


Summary (updated)
-

Added a new '/files' endpoints test using authentication.


Bugs: MESOS-4956
https://issues.apache.org/jira/browse/MESOS-4956


Repository: mesos


Description (updated)
---

A new test was added (FilesTest.AuthenticationTest) to the FilesTests, and 
existing tests were modified, to probe the endpoints' behavior with and without 
HTTP authentication.


Diffs (updated)
-

  src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e 

Diff: https://reviews.apache.org/r/45249/diff/


Testing
---

`sudo make check` was used to test on OSX and CentOS 7.


Thanks,

Greg Mann