Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

2016-04-04 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45313/
---

(Updated April 4, 2016, 8:19 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Bugs: MESOS-5112
https://issues.apache.org/jira/browse/MESOS-5112


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
64102e1f31437d4271a1126e339fb2f33f0181b8 

Diff: https://reviews.apache.org/r/45313/diff/


Testing
---

`make check`


Thanks,

Michael Park



Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

2016-04-04 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45313/#review126798
---


Ship it!




Ship It!

- Daniel Pravat


On March 28, 2016, 8:57 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45313/
> ---
> 
> (Updated March 28, 2016, 8:57 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> 64102e1f31437d4271a1126e339fb2f33f0181b8 
> 
> Diff: https://reviews.apache.org/r/45313/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>



Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.

2016-03-28 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45313/
---

(Updated March 28, 2016, 8:57 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
---

Addressed Daniel's comments.


Summary (updated)
-

Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.


Repository: mesos


Description (updated)
---

Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
64102e1f31437d4271a1126e339fb2f33f0181b8 

Diff: https://reviews.apache.org/r/45313/diff/


Testing
---

`make check`


Thanks,

Michael Park