Re: Review Request 45377: Updated prepare() logic for unified container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review128981 --- Patch looks great! Reviews applied: [45214, 45217, 45270, 45360, 45373, 45326, 46180, 45370, 44454, 45377] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 14, 2016, 4:30 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45377/ > --- > > (Updated April 14, 2016, 4:30 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > --- > > Updated prepare() logic for unified container. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > PRE-CREATION > src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 > > Diff: https://reviews.apache.org/r/45377/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 45377: Updated prepare() logic for unified container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 14, 2016, 4:30 p.m.) Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu. Bugs: MESOS-5013 https://issues.apache.org/jira/browse/MESOS-5013 Repository: mesos Description --- Updated prepare() logic for unified container. Diffs (updated) - src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp PRE-CREATION src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 Diff: https://reviews.apache.org/r/45377/diff/ Testing (updated) --- make make check Thanks, Guangya Liu
Re: Review Request 45377: Updated prepare() logic for unified container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review126981 --- Could we keep the cli/execute.cpp changes private for now? and rebase this with the prepare() method implementation. - Gilbert Song On April 4, 2016, 2:28 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45377/ > --- > > (Updated April 4, 2016, 2:28 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > --- > > Updated prepare() logic for unified container. > > > Diffs > - > > src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45377/diff/ > > > Testing > --- > > Updating the execute.cpp for test, will remove it once test finished. > > > Thanks, > > Guangya Liu > >
Re: Review Request 45377: Updated prepare() logic for unified container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 4, 2016, 9:28 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5013 https://issues.apache.org/jira/browse/MESOS-5013 Repository: mesos Description --- Updated prepare() logic for unified container. Diffs (updated) - src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45377/diff/ Testing --- Updating the execute.cpp for test, will remove it once test finished. Thanks, Guangya Liu
Re: Review Request 45377: Updated prepare() logic for unified container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 2, 2016, 1:46 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) - Updated prepare() logic for unified container. Bugs: MESOS-5013 https://issues.apache.org/jira/browse/MESOS-5013 Repository: mesos Description (updated) --- Updated prepare() logic for unified container. Diffs (updated) - src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45377/diff/ Testing (updated) --- Updating the execute.cpp for test, will remove it once test finished. Thanks, Guangya Liu
