Re: Review Request 45461: Create tempfiles in test temporary directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45461/#review126951 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 5:26 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45461/ > --- > > (Updated March 30, 2016, 5:26 p.m.) > > > Review request for mesos, Bernd Mathiske and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Create tempfiles in test temporary directory. > > Previously, some tests were creating tempfiles outside of the temporary > directory created by the test case and then manually removing them, which > could lead to their being leaked if the test were interrupted. > > > Diffs > - > > src/tests/fetcher_tests.cpp 84c8d487bbf61c77452bd293062a80fa132e069f > > Diff: https://reviews.apache.org/r/45461/diff/ > > > Testing > --- > > This change merely creates all temporary files used in the process of running > fetcher tests inside of the temp directories created by the test case, so no > further testing was performed. > > > Thanks, > > Michael Browning > >
Re: Review Request 45461: Create tempfiles in test temporary directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45461/#review126043 --- Patch looks great! Reviews applied: [45461] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 29, 2016, 11:55 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45461/ > --- > > (Updated March 29, 2016, 11:55 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Create tempfiles in test temporary directory. > > Previously, some tests were creating tempfiles outside of the temporary > directory created by the test case and then manually removing them, which > could lead to their being leaked if the test were interrupted. > > > Diffs > - > > src/tests/fetcher_tests.cpp 84c8d487bbf61c77452bd293062a80fa132e069f > > Diff: https://reviews.apache.org/r/45461/diff/ > > > Testing > --- > > This change merely creates all temporary files used in the process of running > fetcher tests inside of the temp directories created by the test case, so no > further testing was performed. > > > Thanks, > > Michael Browning > >
Review Request 45461: Create tempfiles in test temporary directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45461/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Create tempfiles in test temporary directory. Previously, some tests were creating tempfiles outside of the temporary directory created by the test case and then manually removing them, which could lead to their being leaked if the test were interrupted. Diffs - src/tests/fetcher_tests.cpp 84c8d487bbf61c77452bd293062a80fa132e069f Diff: https://reviews.apache.org/r/45461/diff/ Testing --- This change merely creates all temporary files used in the process of running fetcher tests inside of the temp directories created by the test case, so no further testing was performed. Thanks, Michael Browning
