Re: Review Request 45707: Minor cleanups to command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127071 --- Ship it! Ship It! - Qian Zhang On April 5, 2016, 5:32 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45707/ > --- > > (Updated April 5, 2016, 5:32 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Trivial cleanups: > - Not capture boolean arguments by reference. > - Added newline after a statement. > > > Diffs > - > > src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 > > Diff: https://reviews.apache.org/r/45707/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 45707: Minor cleanups to command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127009 --- Ship it! Ship It! - Klaus Ma On April 5, 2016, 5:32 a.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45707/ > --- > > (Updated April 5, 2016, 5:32 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Trivial cleanups: > - Not capture boolean arguments by reference. > - Added newline after a statement. > > > Diffs > - > > src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 > > Diff: https://reviews.apache.org/r/45707/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 45707: Minor cleanups to command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127005 --- Patch looks great! Reviews applied: [45707] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 4, 2016, 9:32 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45707/ > --- > > (Updated April 4, 2016, 9:32 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Trivial cleanups: > - Not capture boolean arguments by reference. > - Added newline after a statement. > > > Diffs > - > > src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 > > Diff: https://reviews.apache.org/r/45707/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 45707: Minor cleanups to command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review126954 --- Ship it! Ship It! - Timothy Chen On April 4, 2016, 9:32 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45707/ > --- > > (Updated April 4, 2016, 9:32 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Trivial cleanups: > - Not capture boolean arguments by reference. > - Added newline after a statement. > > > Diffs > - > > src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 > > Diff: https://reviews.apache.org/r/45707/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Review Request 45707: Minor cleanups to command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Description --- Trivial cleanups: - Not capture boolean arguments by reference. - Added newline after a statement. Diffs - src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526 Diff: https://reviews.apache.org/r/45707/diff/ Testing --- make check Thanks, Anand Mazumdar
