Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/#review129062
---



Patch looks great!

Reviews applied: [46214]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 1:51 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46214/
> ---
> 
> (Updated April 15, 2016, 1:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5184
> https://issues.apache.org/jira/browse/MESOS-5184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Valided role when framework subscribe.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
> 
> Diff: https://reviews.apache.org/r/46214/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/
---

(Updated April 15, 2016, 9:51 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address @vinod's comments :).


Bugs: MESOS-5184
https://issues.apache.org/jira/browse/MESOS-5184


Repository: mesos


Description
---

Valided role when framework subscribe.


Diffs (updated)
-

  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
  src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
  src/tests/scheduler_http_api_tests.cpp 
d469adf7230ce5bb5e71a241a06e389295905e03 

Diff: https://reviews.apache.org/r/46214/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/#review129035
---




src/tests/master_tests.cpp (lines 4081 - 4083)


s/err/error/



src/tests/master_tests.cpp (line 4088)


Instead of driver.join() you should do a ASSERT_READY(error) to make sure 
that the error has happened. You can still do a driver.join() afterwards, 
though strictly not necessary.


- Vinod Kone


On April 14, 2016, 4:11 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46214/
> ---
> 
> (Updated April 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5184
> https://issues.apache.org/jira/browse/MESOS-5184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Valided role when framework subscribe.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
> 
> Diff: https://reviews.apache.org/r/46214/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/#review128960
---



Patch looks great!

Reviews applied: [46214]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 14, 2016, 4:11 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46214/
> ---
> 
> (Updated April 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5184
> https://issues.apache.org/jira/browse/MESOS-5184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Valided role when framework subscribe.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
> 
> Diff: https://reviews.apache.org/r/46214/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5184
https://issues.apache.org/jira/browse/MESOS-5184


Repository: mesos


Description
---

Valided role when framework subscribe.


Diffs
-

  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
  src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
  src/tests/scheduler_http_api_tests.cpp 
d469adf7230ce5bb5e71a241a06e389295905e03 

Diff: https://reviews.apache.org/r/46214/diff/


Testing
---

make && make check


Thanks,

Klaus Ma