Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/#review167476
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 20, 2016, 4:50 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46227/
> ---
> 
> (Updated Nov. 20, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a persistent volume is created, it is created with the user
> indicated in Resource::DiskInfo::Persistence. If missing, it would
> fall back to make the user of the mesos-slave process as the owner
> of the persistent volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
>   include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 
> 
> 
> Diff: https://reviews.apache.org/r/46227/diff/4/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/
---

(Updated Nov. 20, 2016, 4:50 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

rebased.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

When a persistent volume is created, it is created with the user
indicated in Resource::DiskInfo::Persistence. If missing, it would
fall back to make the user of the mesos-slave process as the owner
of the persistent volume.


Diffs (updated)
-

  include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
  include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 

Diff: https://reviews.apache.org/r/46227/diff/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/#review155972
---


Ship it!




Ship It!

- Greg Mann


On Oct. 18, 2016, 7:42 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46227/
> ---
> 
> (Updated Oct. 18, 2016, 7:42 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a persistent volume is created, it is created with the user
> indicated in Resource::DiskInfo::Persistence. If missing, it would
> fall back to make the user of the mesos-slave process as the owner
> of the persistent volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe 
>   include/mesos/v1/mesos.proto def33ef5e446576c86da0498e8a24e2e2de17918 
> 
> Diff: https://reviews.apache.org/r/46227/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/
---

(Updated Oct. 18, 2016, 7:42 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Addressed review comments, and rebased.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

When a persistent volume is created, it is created with the user
indicated in Resource::DiskInfo::Persistence. If missing, it would
fall back to make the user of the mesos-slave process as the owner
of the persistent volume.


Diffs (updated)
-

  include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe 
  include/mesos/v1/mesos.proto def33ef5e446576c86da0498e8a24e2e2de17918 

Diff: https://reviews.apache.org/r/46227/diff/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/#review144147
---




include/mesos/mesos.proto (line 711)


s/mesos-slave/mesos-agent/



include/mesos/v1/mesos.proto (line 710)


s/mesos-slave/mesos-agent/


- Greg Mann


On April 14, 2016, 11:07 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46227/
> ---
> 
> (Updated April 14, 2016, 11:07 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4893
> https://issues.apache.org/jira/browse/MESOS-4893
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a persistent volume is created, it is created with the user
> indicated in Resource::DiskInfo::Persistence. If missing, it would
> fall back to make the user of the mesos-slave process as the owner
> of the persistent volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
> 
> Diff: https://reviews.apache.org/r/46227/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/
---

(Updated April 14, 2016, 11:07 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

rebased to HEAD.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

When a persistent volume is created, it is created with the user
indicated in Resource::DiskInfo::Persistence. If missing, it would
fall back to make the user of the mesos-slave process as the owner
of the persistent volume.


Diffs (updated)
-

  include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
  include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 

Diff: https://reviews.apache.org/r/46227/diff/


Testing
---

All tests passed.


Thanks,

Anindya Sinha

Review Request 46227: Added an user to indicate owner of persistent volume.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46227/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4893
https://issues.apache.org/jira/browse/MESOS-4893


Repository: mesos


Description
---

When a persistent volume is created, it is created with the user
indicated in Resource::DiskInfo::Persistence. If missing, it would
fall back to make the user of the mesos-slave process as the owner
of the persistent volume.


Diffs
-

  include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
  include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am 1ae0ea7f3ff6f136d58ef08e7b11185ea19f37a8 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
0ad473dc3bd45e122fba55a670e1a893e61c977a 

Diff: https://reviews.apache.org/r/46227/diff/


Testing
---

All tests passed.


Thanks,

Anindya Sinha