Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133572
---



Patch looks great!

Reviews applied: [47281]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 17, 2016, 12:32 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 17, 2016, 12:32 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
>   src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
>   src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
>   src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> e4579cb7978c966f639c0d2c196884e522b372c2 
>   src/tests/http_fault_tolerance_tests.cpp 
> baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 5c221f059585d49be5848bc0b655adab6b02 
>   src/tests/master_maintenance_tests.cpp 
> 971c4473acbec5206614f46f51b06b3460595d50 
>   src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
> 
> Diff: https://reviews.apache.org/r/47281/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-17 Thread Jose Guilherme Vanz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/
---

(Updated May 17, 2016, 12:32 p.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-2516
https://issues.apache.org/jira/browse/MESOS-2516


Repository: mesos


Description
---

To keep consistence with the rest of the codebase, the allocation
namespace has been removed from mesos::master namespace. To not
pollute the master namespace, sorters have been moved to the new
mesos::master::sorter namespace

MESOS-2516


Diffs (updated)
-

  docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
  src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
51125bac62735879f66234765dad92a759f6724b 
  src/master/allocator/mesos/metrics.hpp 
06fdd1633f63c005230e1cc5fafdad358a0ac254 
  src/master/allocator/mesos/metrics.cpp 
a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
c793f3216287fd40998a1d4aab016d55aa1ac151 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
  src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
  src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
  src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
  src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
  src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
  src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
  src/tests/fault_tolerance_tests.cpp c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
  src/tests/hierarchical_allocator_tests.cpp 
e4579cb7978c966f639c0d2c196884e522b372c2 
  src/tests/http_fault_tolerance_tests.cpp 
baa07395b9bd588daa5438369954584787d7952a 
  src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
  src/tests/master_authorization_tests.cpp 
5c221f059585d49be5848bc0b655adab6b02 
  src/tests/master_maintenance_tests.cpp 
971c4473acbec5206614f46f51b06b3460595d50 
  src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 

Diff: https://reviews.apache.org/r/47281/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133382
---


Fix it, then Ship it!




Ship It!


src/local/local.cpp 


Kill this line.



src/master/allocator/mesos/hierarchical.hpp (line 46)


Add a blank line above.



src/tests/master_allocator_tests.cpp (line 58)


Kill this line



src/tests/rate_limiting_tests.cpp (line 41)


I think this line is unecessary here because `using namespace` before.



src/tests/reservation_tests.cpp (line 52)


Kill this line.


- haosdent huang


On May 14, 2016, 6:25 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 14, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
>   src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
>   src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
>   src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> d75df737d2a62c77176cc02fc47362943c29b551 
>   src/tests/http_fault_tolerance_tests.cpp 
> baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 5c221f059585d49be5848bc0b655adab6b02 
>   src/tests/master_maintenance_tests.cpp 
> 971c4473acbec5206614f46f51b06b3460595d50 
>   src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
> 
> Diff:

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133287
---



Patch looks great!

Reviews applied: [47281]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 6:25 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 14, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
>   src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
>   src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
>   src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> d75df737d2a62c77176cc02fc47362943c29b551 
>   src/tests/http_fault_tolerance_tests.cpp 
> baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 5c221f059585d49be5848bc0b655adab6b02 
>   src/tests/master_maintenance_tests.cpp 
> 971c4473acbec5206614f46f51b06b3460595d50 
>   src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
> 
> Diff: https://reviews.apache.org/r/47281/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread Jose Guilherme Vanz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/
---

(Updated May 14, 2016, 6:25 p.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-2516
https://issues.apache.org/jira/browse/MESOS-2516


Repository: mesos


Description
---

To keep consistence with the rest of the codebase, the allocation
namespace has been removed from mesos::master namespace. To not
pollute the master namespace, sorters have been moved to the new
mesos::master::sorter namespace

MESOS-2516


Diffs (updated)
-

  docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
  src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
51125bac62735879f66234765dad92a759f6724b 
  src/master/allocator/mesos/metrics.hpp 
06fdd1633f63c005230e1cc5fafdad358a0ac254 
  src/master/allocator/mesos/metrics.cpp 
a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
c793f3216287fd40998a1d4aab016d55aa1ac151 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
  src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
  src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
  src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
  src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
  src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
  src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
  src/tests/fault_tolerance_tests.cpp c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
  src/tests/hierarchical_allocator_tests.cpp 
d75df737d2a62c77176cc02fc47362943c29b551 
  src/tests/http_fault_tolerance_tests.cpp 
baa07395b9bd588daa5438369954584787d7952a 
  src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
  src/tests/master_authorization_tests.cpp 
5c221f059585d49be5848bc0b655adab6b02 
  src/tests/master_maintenance_tests.cpp 
971c4473acbec5206614f46f51b06b3460595d50 
  src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 

Diff: https://reviews.apache.org/r/47281/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133265
---




src/local/local.cpp (line 93)


Kill this line because it is belong to same `using` with following using 
items.



src/master/allocator/mesos/hierarchical.hpp (line 45)


I suggest to using excactly using here instead of use `using namespace`



src/tests/hierarchical_allocator_tests.cpp (line 54)


Put it on the `using mesos::internal::master::MIN_CPUS;`



src/tests/master_allocator_tests.cpp (line 55)


Add a blank line between them



src/tests/master_authorization_tests.cpp (line 49)


Kill this line.



src/tests/master_tests.cpp (line 74)


Kill this blank line



src/tests/scheduler_driver_tests.cpp (line 49)


Put it after `using mesos::internal::master::Master;`



src/tests/scheduler_tests.cpp (line 55)


Put it after `using mesos::internal::master::Master;`


- haosdent huang


On May 12, 2016, 2:02 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 12, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
>   src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> e6101fdffe5e340619d79d821a2f5f891cb2dec7 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review132868
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 12, 2016, 2:02 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 12, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
>   src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> e6101fdffe5e340619d79d821a2f5f891cb2dec7 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
> 
> Diff: https://reviews.apache.org/r/47281/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-11 Thread Jose Guilherme Vanz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/
---

Review request for mesos.


Bugs: MESOS-2516
https://issues.apache.org/jira/browse/MESOS-2516


Repository: mesos


Description
---

To keep consistence with the rest of the codebase, the allocation
namespace has been removed from mesos::master namespace. To not
pollute the master namespace, sorters have been moved to the new
mesos::master::sorter namespace

MESOS-2516


Diffs
-

  docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
51125bac62735879f66234765dad92a759f6724b 
  src/master/allocator/mesos/metrics.hpp 
06fdd1633f63c005230e1cc5fafdad358a0ac254 
  src/master/allocator/mesos/metrics.cpp 
a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
c793f3216287fd40998a1d4aab016d55aa1ac151 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
  src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
  src/tests/fault_tolerance_tests.cpp c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
  src/tests/hierarchical_allocator_tests.cpp 
e6101fdffe5e340619d79d821a2f5f891cb2dec7 
  src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
  src/tests/master_authorization_tests.cpp 
804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
  src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 

Diff: https://reviews.apache.org/r/47281/diff/


Testing
---


Thanks,

Jose Guilherme Vanz