Re: Review Request 47519: Updated an example framework to specify its principal.

2016-05-26 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47519/#review135091
---


Ship it!




Ship It!

- Till Toenshoff


On May 18, 2016, 8:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47519/
> ---
> 
> (Updated May 18, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the creator principal into the
> persistent volumes created by the persistent volume
> example framework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> 53a6f6f82101ebb75abdc8f586fb23ab13298979 
> 
> Diff: https://reviews.apache.org/r/47519/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with the following commands:
> `bin/mesos-master.sh --ip=127.0.0.1 --work_dir="$HOME/var/mesos1" 
> --authenticate=false`
> `bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir="$HOME/var/mesos2" 
> --"resources=disk(test):2048;mem(test):2048;cpu(test):4"`
> `src/persistent-volume-framework --master=127.0.0.1:5050`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 47519: Updated an example framework to specify its principal.

2016-05-23 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47519/#review134347
---


Ship it!




Ship It!

- Bernd Mathiske


On May 18, 2016, 1:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47519/
> ---
> 
> (Updated May 18, 2016, 1:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the creator principal into the
> persistent volumes created by the persistent volume
> example framework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> 53a6f6f82101ebb75abdc8f586fb23ab13298979 
> 
> Diff: https://reviews.apache.org/r/47519/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with the following commands:
> `bin/mesos-master.sh --ip=127.0.0.1 --work_dir="$HOME/var/mesos1" 
> --authenticate=false`
> `bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir="$HOME/var/mesos2" 
> --"resources=disk(test):2048;mem(test):2048;cpu(test):4"`
> `src/persistent-volume-framework --master=127.0.0.1:5050`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 47519: Updated an example framework to specify its principal.

2016-05-18 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47519/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch adds the creator principal into the
persistent volumes created by the persistent volume
example framework.


Diffs
-

  src/examples/persistent_volume_framework.cpp 
53a6f6f82101ebb75abdc8f586fb23ab13298979 

Diff: https://reviews.apache.org/r/47519/diff/


Testing
---

Tested manually with the following commands:
`bin/mesos-master.sh --ip=127.0.0.1 --work_dir="$HOME/var/mesos1" 
--authenticate=false`
`bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir="$HOME/var/mesos2" 
--"resources=disk(test):2048;mem(test):2048;cpu(test):4"`
`src/persistent-volume-framework --master=127.0.0.1:5050`


Thanks,

Greg Mann