Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review136730
---


Ship it!




Thanks!

- Benjamin Mahler


On May 23, 2016, 6:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5436
> https://issues.apache.org/jira/browse/MESOS-5436
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> # For apgent framework page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)
> 
> # For agent page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/
---

(Updated May 23, 2016, 6:11 p.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.


Changes
---

Update bugs link


Bugs: MESOS-5436
https://issues.apache.org/jira/browse/MESOS-5436


Repository: mesos


Description
---

Removed invalid gpu statistics columns in framework data tables.


Diffs
-

  src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
  src/webui/master/static/agent_framework.html 
4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 

Diff: https://reviews.apache.org/r/47719/diff/


Testing
---

# For apgent framework page:
## Before:
![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
## After:
![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)

# For agent page:
## Before:
![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
## After:
![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)


Thanks,

haosdent huang

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[Kevin Klues]

Can you also link the issue back to the review in JIRA:

Workflow -> Post Review

https://issues.apache.org/jira/browse/MESOS-5436

On Mon, May 23, 2016 at 11:02 AM, haosdent huang  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
>
> On May 23rd, 2016, 5:29 p.m. UTC, *Kevin Klues* wrote:
>
> Looks good.  Just curous -- how did you upload the pictures to the testing 
> section?  Is there someway to make them smaller next time?
>
> LoL I upload it via jira and use ![](image_link) to show it in reviewboard. 
> Seems reviewboard don't allow specify the image width and height, I would 
> resize them before upload next time. ;-)
>
>
> - haosdent
>
> On May 23rd, 2016, 4:56 p.m. UTC, haosdent huang wrote:
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> By haosdent huang.
>
> *Updated May 23, 2016, 4:56 p.m.*
> *Bugs: * MESOS-5157 
> *Repository: * mesos
> Description
>
> Removed invalid gpu statistics columns in framework data tables.
>
> Testing
>
> For apgent framework page:Before:
>
> After:
>
> For agent page:Before:
>
> After:
>
> Diffs
>
>- src/webui/master/static/agent.html
>(2f40034cf89e5f92ace3043578881b7b7157e25f)
>- src/webui/master/static/agent_framework.html
>(4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5)
>
> View Diff 
>



-- 
~Kevin

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[haosdent huang]

> On May 23, 2016, 5:29 p.m., Kevin Klues wrote:
> > Looks good.  Just curous -- how did you upload the pictures to the testing 
> > section?  Is there someway to make them smaller next time?

LoL I upload it via jira and use `![](image_link)` to show it in reviewboard. 
Seems reviewboard don't allow specify the image width and height, I would 
resize them before upload next time. ;-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134395
---


On May 23, 2016, 4:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> # For apgent framework page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)
> 
> # For agent page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134406
---



Patch looks great!

Reviews applied: [47719]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 4:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> # For apgent framework page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)
> 
> # For agent page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[haosdent huang]

> On May 23, 2016, 4:16 p.m., Kevin Klues wrote:
> > I don't think we want to remove the headers.  Instead, we want to add 
> > column bodies with 0 values or "N/A" ass appropriate.
> 
> haosdent huang wrote:
> Got it, already updated. Let me upload the screenshots as well.

Just update the screenshots, @klueska, may you help review this again? Thank 
you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134374
---


On May 23, 2016, 4:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> # For apgent framework page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)
> 
> # For agent page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[haosdent huang]

> On May 23, 2016, 4:16 p.m., Kevin Klues wrote:
> > I don't think we want to remove the headers.  Instead, we want to add 
> > column bodies with 0 values or "N/A" ass appropriate.

Got it, already updated. Let me upload the screenshots as well.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134374
---


On May 23, 2016, 4:40 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134337
---



Patch looks great!

Reviews applied: [47719]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 8:43 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> ---
> 
> (Updated May 23, 2016, 8:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
> https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 
> 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 
> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/
---

Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.


Bugs: MESOS-5157
https://issues.apache.org/jira/browse/MESOS-5157


Repository: mesos


Description
---

Removed invalid gpu statistics columns in framework data tables.


Diffs
-

  src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
  src/webui/master/static/agent_framework.html 
4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5 

Diff: https://reviews.apache.org/r/47719/diff/


Testing
---


Thanks,

haosdent huang