Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 17, 2016, 6:10 a.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review138135
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 11:03 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5628
> https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
> updated to send only one authorization request per action.
> 
> In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
> Note that `QuotaHandler` encodes the type of the request (set or remove)
> by setting the `value` field of `Object` to `"SetQuota"` or
> `"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
> `ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 558f332b3a5382cee64fb1dcf57b110e481b1efc 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 11:03 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing (updated)
---

`make check`


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:20 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:10 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 9:45 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 9:02 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 8:43 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 3c0fe048635abb3a9bea8399050e2ca2d823262d 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 


> On May 30, 2016, 4:17 p.m., Joerg Schad wrote:
> > src/authorizer/local/authorizer.cpp, line 59
> > 
> >
> > Just curious: will we keep this around after the deprecation cycle?

Left a comment to point out that this class can be removed after the 
deprecation cycle.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135524
---


On June 16, 2016, 5:59 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 3c0fe048635abb3a9bea8399050e2ca2d823262d 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 


> On May 30, 2016, 9:39 p.m., Alexander Rukletsov wrote:
> > src/authorizer/local/authorizer.cpp, line 352
> > 
> >
> > Introducing `approved()`  looks like a general enhancement. Maybe do it 
> > in a separate patch?

This was done in https://reviews.apache.org/r/48052/


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135548
---


On June 16, 2016, 5:59 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 3c0fe048635abb3a9bea8399050e2ca2d823262d 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 


> On May 30, 2016, 9:39 p.m., Alexander Rukletsov wrote:
> > src/authorizer/local/authorizer.cpp, lines 369-373
> > 
> >
> > You make these now private. Is it on purpose? Do you want to do it in a 
> > separate patch explaining the reasoning?

This was fixed in Joerg's earlier patches, and therefore is not a part of this 
patch anymore.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135548
---


On June 16, 2016, 5:59 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 3c0fe048635abb3a9bea8399050e2ca2d823262d 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 5:59 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Changes
---

rebased.


Repository: mesos


Description (updated)
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 3c0fe048635abb3a9bea8399050e2ca2d823262d 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-05-30 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135548
---




src/authorizer/local/authorizer.cpp (line 349)


Introducing `approved()`  looks like a general enhancement. Maybe do it in 
a separate patch?



src/authorizer/local/authorizer.cpp (lines 364 - 367)


You make these now private. Is it on purpose? Do you want to do it in a 
separate patch explaining the reasoning?


- Alexander Rukletsov


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-05-30 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135524
---




src/authorizer/local/authorizer.cpp (line 59)


Just curious: will we keep this around after the deprecation cycle?


- Joerg Schad


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-05-30 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park