Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-06-16 Thread Michael Park 


> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote:
> > src/master/quota_handler.cpp, lines 575-580
> > 
> >
> > Is there a JIRA around introducing LocalAuthorizer specific deprecation 
> > cycles - I would like to understand why we are not pushing this request out 
> > to any authorizer (module).
> 
> Alexander Rukletsov wrote:
> There is no JIRA afaik. In short, the reason why local authorizer is 
> "special" is because the authorizer interface has been refactored in 0.29 and 
> hence we can simply avoid introducing enum values corresponding to the quota 
> authz actions being deprecated in 0.29. However, we still must support 
> related ACLs, which are relevant only to local authorizer. In one sentence: 
> any authorizer (module) is revamped in 0.29 hence no deprecation is needed, 
> while LocalAuthorizer should go through deprecation.

@Till: We've removed this check and decided to always set the `value` field. 
Note that this is still an internal hack, thus we do not claim to set the 
`value` field at the public API level.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
---


On June 16, 2016, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated June 16, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `QuotaHandler` to only one authorization request per action.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-06-16 Thread Michael Park 


> On May 30, 2016, 9:39 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 40
> > 
> >
> > Let's add a todo here that this dependency is temporary.

I've removed the `dynamic_cast` to `LocalAuthorizer` and therefore also removed 
this dependency.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135549
---


On June 16, 2016, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated June 16, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `QuotaHandler` to only one authorization request per action.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 9:45 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `QuotaHandler` to only one authorization request per action.


Diffs (updated)
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-06-16 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 5:59 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Changes
---

rebased.


Repository: mesos


Description (updated)
---

Updated `QuotaHandler` to only one authorization request per action.


Diffs (updated)
-

  src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-05-30 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135549
---




src/master/master.hpp 


Though this is currently not necessary, could you please leave a todo here, 
that after the deprecation cycle we should introduce this method instead of 
other two below?



src/master/quota_handler.cpp (line 40)


Let's add a todo here that this dependency is temporary.



src/master/quota_handler.cpp (line 500)


Please wrap for consistency.



src/master/quota_handler.cpp (line 533)


ditto


- Alexander Rukletsov


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-05-30 Thread Alexander Rukletsov 


> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote:
> > src/master/quota_handler.cpp, lines 575-580
> > 
> >
> > Is there a JIRA around introducing LocalAuthorizer specific deprecation 
> > cycles - I would like to understand why we are not pushing this request out 
> > to any authorizer (module).

There is no JIRA afaik. In short, the reason why local authorizer is "special" 
is because the authorizer interface has been refactored in 0.29 and hence we 
can simply avoid introducing enum values corresponding to the quota authz 
actions being deprecated in 0.29. However, we still must support related ACLs, 
which are relevant only to local authorizer. In one sentence: any authorizer 
(module) is revamped in 0.29 hence no deprecation is needed, while 
LocalAuthorizer should go through deprecation.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
---


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-05-30 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
---




src/master/quota_handler.cpp (lines 517 - 522)


Is there a JIRA around introducing LocalAuthorizer specific deprecation 
cycles - I would like to understand why we are not pushing this request out to 
any authorizer (module).


- Till Toenshoff


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

2016-05-30 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
  src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park